stabilize test #7304
main fromstabilize-test-3004·opened Summary by CodeRabbit#
- Tests
- Optimized HMR (Hot Module Reloading) test helper logic for improved reliability and reduced test execution time.
Note: This release contains internal test infrastructure improvements with no user-facing changes.
- 1
View your CI Pipeline Execution ↗ for commit 4af0509f5f6b2ff16a93c712362b5cc57f4e3a15
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...❌ Failed 5m 18s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 14s View ↗
☁️ Nx Cloud last updated this comment at
2026-04-30 20:00:54UTC🚀 Changeset Version Preview#
1 package(s) bumped directly, 4 bumped as dependents.
🟩 Patch bumps#
Package Version Reason @tanstack/start-plugin-core1.169.8 → 1.169.9 Changeset @tanstack/react-start1.167.53 → 1.167.54 Dependent @tanstack/react-start-rsc0.0.32 → 0.0.33 Dependent @tanstack/solid-start1.167.50 → 1.167.51 Dependent @tanstack/vue-start1.167.46 → 1.167.47 Dependent More templates
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-router-react-example-basic-authjs
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-example-rscs
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
- tanstack-router-vue-example-basic-jsx
- tanstack-router-vue-example-basic-file-based-jsx
- tanstack-router-vue-example-basic-file-based-sfc
- tanstack-router-solid-example-authenticated-routes
- tanstack-router-solid-example-authenticated-routes-firebase
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-default-search-params
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-basic-virtual-file-based
- tanstack-router-solid-example-basic-virtual-inside-file-based
- tanstack-router-solid-example-deferred-data
- tanstack-router-solid-i18n-paraglide
- tanstack-router-solid-example-kitchen-sink
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-large-file-based
- tanstack-router-solid-example-location-masking
- tanstack-router-solid-example-navigation-blocking
- tanstack-router-solid-example-quickstart
- tanstack-router-solid-example-quickstart-esbuild-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-router-solid-example-quickstart-rspack-file-based
- tanstack-router-solid-example-quickstart-webpack-file-based
- @tanstack/router-solid-mono-simple
- router-solid-mono-simple-lazy
- router-solid-monorepo-solid-query
- tanstack-router-solid-example-scroll-restoration
- tanstack-solid-router-search-validator-adapters
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-authjs
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
- tanstack-solid-start-bun-hosting
- tanstack-solid-start-example-convex-better-auth
- tanstack-solid-start-example-counter
- tanstack-solid-start-i18n-paraglide
- tanstack-solid-start-example-large
- tanstack-solid-start-streaming-data-from-server-functions
- tanstack-solid-start-example-supabase-basic
- tanstack-solid-start-tailwind-v4
- tanstack-router-solid-example-view-transitions
- tanstack-router-solid-example-with-framer-motion
- tanstack-router-solid-example-with-trpc
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@7304@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7304@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7304@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@7304@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7304@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@7304@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@7304@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7304@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@7304@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@7304@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@7304@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@7304@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@7304@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@7304@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@7304@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@7304@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@7304@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@7304@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7304@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@7304@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7304@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@7304@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7304@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7304@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@7304@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@7304@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@7304@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@7304@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7304@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@7304@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@7304@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7304@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@7304@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@7304@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7304@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@7304@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7304@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7304@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@7304@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@7304@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@7304@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@7304commit:
55af04eNx Cloud has identified a flaky task in your failed CI:#
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
View detailed reasoning in Nx Cloud ↗
🎓 Learn more about Self-Healing CI on [nx.dev](https://nx.dev/docs/features/ci-features/self-healing-ci?utm_source=pull-request&utm_medium=comment)Nx Cloud has identified a flaky task in your failed CI:#
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
View detailed reasoning in Nx Cloud ↗
🎓 Learn more about Self-Healing CI on [nx.dev](https://nx.dev/docs/features/ci-features/self-healing-ci?utm_source=pull-request&utm_medium=comment)Superseded by #8277, which builds on this contribution and consolidates the related HMR and missing-chunk recovery fixes. Contributor credit is preserved in the replacement.
Sign in to join this conversation.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID:
91f04314-a7ef-4076-8a22-79379d2552d9📥 Commits
Reviewing files that changed from the base of the PR and between dad0ec8f41fbc11a8c964604cdbbfa51ab1a40ae and 4af0509f5f6b2ff16a93c712362b5cc57f4e3a15.
📒 Files selected for processing (1)
e2e/react-start/hmr/tests/app.spec.ts📝 Walkthrough
Walkthrough#
The test helper
restoreRouteFilesis simplified to restore only when file content differs from the original. ThebeforeEachlogic transitions from array-based to set-based pending-key tracking. Two HMR test scenarios remove explicit waits (one removes a hydration-safe reload step, another removes a 300ms timeout), and a root loader test adds an assertion after the first increment click.Changes#
e2e/react-start/hmr/tests/app.spec.tsrestoreRouteFileshelper to remove forced key acceptance; refactoredbeforeEachfrom array to set-based pending tracking; removed explicit hydration-safe reload and 300ms timeout steps from two HMR scenarios; added count assertion after first increment in root loader test.Estimated code review effort#
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem#
🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)#
✅ Passed checks (3 passed)
✨ Finishing Touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment `@coderabbitai help` to get the list of available commands and usage tips.