Skip to content
Source
Sign inSign up
TanStack/router

ssr.nonce set after the router is created no longer reaches the hydration scripts (regression in 1.171.31) #8789

Send to my agent
OpenTrevorBurnham(GitHub profile, opens in a new tab) opened this issue 2 comments

Which project does this relate to?

Start

Describe the bug

Since router-core 1.171.31 (#8204), attachRouterServerSsrUtils reads router.options.ssr?.nonce once, when it creates the request's hydration state:

https://github.com/TanStack/router/blob/94d6d8e4/packages/router-core/src/ssr/ssr-server.ts#L406

Before #8204, injectScript and the $tsr barrier script read it each time they wrote a script, so an app could set the nonce after the router was created, for example in the createStartHandler callback. Now the hydration <script data-tsr-stream-part> and the trailing inline <script> render without a nonce, a nonce-based CSP blocks them, and hydration fails with TypeError: Cannot set properties of undefined (setting 't'). The module script still gets the nonce, and nothing fails on the server.

// src/server.ts
const startFetch = createStartHandler((ctx) => {
  const nonce = crypto.randomUUID()
  ctx.router.options.ssr = { ...ctx.router.options.ssr, nonce }
  // ...set `Content-Security-Policy: script-src 'nonce-${nonce}' 'strict-dynamic'`
  return defaultStreamHandler(ctx)
})

Complete minimal reproducer

https://github.com/TrevorBurnham/tanstack-nonce-repro

Steps to Reproduce the Bug

  1. Set ssr.nonce in the createStartHandler callback as above, and send a CSP with script-src 'nonce-<n>'.
  2. Build and serve with router-core 1.171.30 (react-start 1.168.54). Every inline script has the nonce and the page hydrates.
  3. Upgrade to router-core 1.171.31 (react-start 1.168.55). The two inline scripts lose the nonce, the console reports two CSP violations and the TypeError, and the page content disappears. Still present in react-start 1.169.3 (router-core 1.171.38).

Setting the nonce in getRouter() (passing it in as request context) works around it.

Expected behavior

Either the hydration scripts pick up a nonce set any time before rendering, as before, or the docs say ssr.nonce must be set when the router is created, and a dev-mode warning catches a nonce that changes after the SSR utilities are attached.

Platform

  • Router / Start Version: router-core 1.171.31 through 1.171.38 (last working: 1.171.30)
  • OS: macOS, Linux (AWS Lambda)
  • Browser: Chrome
  • Bundler: vite 8.2.1

Sign in to join this conversation.