Skip to content
Source
Sign inSign up
TanStack/router

fix: ensure context is consistent on concurrent match loads #1891

Closedfreshgiammi(GitHub profile, opens in a new tab)wants to merge 3 commits intomain fromrefs/pull/1891/headopened

Showing 3 changed files with 59 additions and 7 deletions.

x
0 of 3 viewed, 3 left
1 addition and 0 deletionspackages/react-router/src/Matches.tsxModified
View file
@@ -48,6 +48,7 @@
searchError: unknown
updatedAt: number
loadPromise: ControlledPromise<void>
+ beforeLoadPromise: ControlledPromise<void>
loaderPromise: Promise<TLoaderData>
loaderData?: TLoaderData
routeContext: TRouteContext
22 additions and 7 deletionspackages/react-router/src/router.tsModified
View file
@@ -1082,6 +1082,7 @@
isFetching: false,
error: undefined,
paramsError: parseErrors[index],
+ beforeLoadPromise: createControlledPromise<void>(),
loaderPromise: Promise.resolve(),
loadPromise,
routeContext: undefined!,
@@ -1785,7 +1786,9 @@
matches[index] = match = updateMatch(match.id, (prev) => ({