Skip to content
Source
Sign inSign up
TanStack/router

fix: render errorElement when route loader is rejected #290

Mergedbadsyntax(GitHub profile, opens in a new tab)merged 1 commit intomain fromrefs/pull/290/headmerged by tannerlinsley

Fixes #255

  • We set the RouteMatch status after loading the elements and (optional) loader
  • The loader can also set the status
  • Thus, we only set the resolved status for RouteMatch'es without loaders, to prevent overriding the status set by the loader

I guess you could rework this logic many ways but i thought this was the easiest to follow.

    1. @badsyntax is attempting to deploy a commit to the Tanstack Team on Vercel.

      A member of the Team first needs to authorize it.

    2. Hoping this gets merged eventually.

    3. tannerlinsley merged thisee8a8a4

    4. tannerlinsley closed this

    5. View your CI Pipeline Execution ↗ for commit 784ece7fa6d902507d47fdf163f5f4747a136a7f.

      CommandStatusDurationResult
      nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 2sView ↗
      nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded<1sView ↗

      ☁️ Nx Cloud last updated this comment at 2025-05-09 02:38:53 UTC

Sign in to join this conversation.