Skip to content
Source
Sign inSign up
TanStack/router

refactor(router-core): Verify changes are necessary before updating store #4964

MergedSheraff(GitHub profile, opens in a new tab)merged 4 commits intomain fromrefs/pull/4964/headmerged by Sheraff(GitHub profile, opens in a new tab)

Showing 2 changed files with 39 additions and 31 deletions.

x
0 of 2 viewed, 2 left
13 additions and 10 deletionspackages/react-router/tests/store-updates-during-navigation.test.tsxModified
View file
@@ -104,12 +104,15 @@
return after - before
​
+function resolveAfter(ms: number, value: any) {
+ return new Promise<void>((resolve) => setTimeout(() => resolve(value), ms))
+}
+​
describe("Store doesn't update *too many* times during navigation", () => {
test('async loader, async beforeLoad, pendingMs', async () => {
const params = setup({
- beforeLoad: () =>
- new Promise<void>((resolve) => setTimeout(resolve, 100)),
- loader: () => new Promise<void>((resolve) => setTimeout(resolve, 100)),
+ beforeLoad: () => resolveAfter(100, { foo: 'bar' }),
+ loader: () => resolveAfter(100, { hello: 'world' }),
defaultPendingMs: 100,
defaultPendingMinMs: 300,
@@ -119,7 +122,7 @@
// This number should be as small as possible to minimize the amount of work
// that needs to be done during a navigation.
// Any change that increases this number should be investigated.
- expect(updates).toBe(14)
+ expect(updates).toBe(10)