Skip to content
Source
Sign inSign up
TanStack/router

Fix(router-devtools-core): Reverts #5374 #5403

Mergedbirkskyum(GitHub profile, opens in a new tab)merged 2 commits intomain fromrefs/pull/5403/headmerged by birkskyum(GitHub profile, opens in a new tab)

Reverts https://github.com/TanStack/router/pull/5374#issuecomment-3378827140

Closes https://github.com/TanStack/router/issues/5391

Summary by CodeRabbit

  • Bug Fixes

    • Corrected package entry points for ESM/CJS, improving import resolution across bundlers and Node environments.
  • Chores

    • Updated Solid.js dependency strategy: moved to a peer dependency (>=1.9.5) to ensure compatibility and reduce duplicates. Users should ensure Solid.js v1.9.5 or newer is installed.
    1. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-devtools-core

    2. Walkthrough

      Adjusts package entry points and exports in packages/router-devtools-core/package.json and reclassifies solid-js across dependencies and peerDependencies.

      Changes

      Cohort / File(s)Summary of changes
      Package metadata
      packages/router-devtools-core/package.json
      Updated main/module to ./dist/cjs/index.cjs and ./dist/esm/index.js; updated exports defaults accordingly; moved solid-js from devDependencies to dependencies and added to peerDependencies (>=1.9.5).

      Sequence Diagram(s)

      Estimated code review effort

      🎯 2 (Simple) | ⏱️ ~8 minutes

      • TanStack/router#5374 — Also modifies router-devtools-core package.json entry points and solid-js dependency placement, but in the opposite direction, indicating a direct relationship.

      Suggested reviewers

      • brenelz
      • schiller-manuel

      Poem

      A nibble of paths, a hop to dist, Exports aligned—no routes are missed. Peer the solid, deps in tow, Devtools thump with steady glow. With whisker-twitch and gentle cheer, The bun declares: “All clear!” 🐇✨

      Pre-merge checks and finishing touches

      ❌ Failed checks (1 inconclusive)
      Check nameStatusExplanationResolution
      Linked Issues Check❓ InconclusiveWhile this PR reverts PR #5374’s export path changes and adds solid-js as a declared dependency and peerDependency, it is not clear from the provided package.json updates alone that the ERR_PACKAGE_PATH_NOT_EXPORTED error for the ‘solid-js/web’ subpath is resolved at runtime. There are no modifications to the solid-js exports or import statements that explicitly address the missing ‘web’ export, so the link to the original issue’s failure mode remains unverified.Please include evidence—such as updated exports for the ‘solid-js/web’ subpath or test results demonstrating a successful runtime import—to confirm that this change fully resolves the reported error.
      ✅ Passed checks (4 passed)
      Check nameStatusExplanation
      Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
      Out of Scope Changes Check✅ PassedAll modifications in this PR are confined to the router-devtools-core package.json, focusing on reverting entry-point paths and adjusting solid-js dependency declarations, which directly relate to the objectives of restoring the prior export configuration and ensuring solid-js is included. There are no unrelated files or features altered in this changeset.
      Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
      Title Check✅ PassedThe title clearly states that this pull request fixes the router-devtools-core package by adding Solid JS to its dependencies, which directly reflects the primary intent of resolving the ERR_PACKAGE_PATH_NOT_EXPORTED issue. It uses a conventional commit style with scope and a concise description of the main change. This ensures anyone reviewing the history understands the core purpose of the update at a glance.
      ✨ Finishing touches
      • 📝 Generate docstrings
        🧪 Generate unit tests (beta)
      • Create PR with unit tests
      • Post copyable unit tests in a comment
      • Commit unit tests in branch `fix(router-devtools-core)--add-solid-js-to-deps`

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands and usage tips.
    3. View your CI Pipeline Execution ↗ for commit 6b6369e4738b7f50f4988965f76ae1e5117ff958

      CommandStatusDurationResult
      nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded6m 47sView ↗
      nx run-many --target=build --exclude=examples/*...✅ Succeeded29sView ↗

      ☁️ Nx Cloud last updated this comment at 2025-10-08 00:24:53 UTC

    4. More templates

      @tanstack/arktype-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5403

      @tanstack/directive-functions-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5403

      @tanstack/eslint-plugin-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5403

      @tanstack/history

      npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5403

      @tanstack/nitro-v2-vite-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5403

      @tanstack/react-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5403

      @tanstack/react-router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5403

      @tanstack/react-router-ssr-query

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5403

      @tanstack/react-start

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5403

      @tanstack/react-start-client

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5403

      @tanstack/react-start-server

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5403

      @tanstack/router-cli

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5403

      @tanstack/router-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5403

      @tanstack/router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5403

      @tanstack/router-devtools-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5403

      @tanstack/router-generator

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5403

      @tanstack/router-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5403

      @tanstack/router-ssr-query-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5403

      @tanstack/router-utils

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5403

      @tanstack/router-vite-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5403

      @tanstack/server-functions-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5403

      @tanstack/solid-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5403

      @tanstack/solid-router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5403

      @tanstack/solid-start

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5403

      @tanstack/solid-start-client

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5403

      @tanstack/solid-start-server

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5403

      @tanstack/start-client-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5403

      @tanstack/start-plugin-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5403

      @tanstack/start-server-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5403

      @tanstack/start-static-server-functions

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5403

      @tanstack/start-storage-context

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5403

      @tanstack/valibot-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5403

      @tanstack/virtual-file-routes

      npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5403

      @tanstack/zod-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5403

      commit: 6b6369e

Sign in to join this conversation.