fix(router-devtools-core): actually bundle solid #5422
main fromrefs/pull/5422/head·merged by birkskyum(GitHub profile, opens in a new tab) closes https://github.com/TanStack/router/issues/5420
I'm not sure why upgrading @tanstack/config causes the build to fail. I could use some help with that as it seems a bit unrelated. I believe this fix should work once we get past that
Summary by CodeRabbit#
- Chores
- Build configuration updated to bundle an additional UI library for more reliable builds across environments.
- Development tooling dependency upgraded to a newer version for improved build compatibility and maintenance.
- Linting configuration cleaned up to remove an unnecessary directive, simplifying developer tooling.
- 1
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-devtools-core
View your CI Pipeline Execution ↗ for commit 5f4e2fcf75aa23f4ba82e237b370464cb784209f
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded 1m 10s View ↗
☁️ Nx Cloud last updated this comment at
2025-10-14 15:02:57UTCActionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 30970808c5e472d8b91f058f6c382cc129e1b380 and 8809a2bf7aed0592ece6dff15b4df2d39e9c418c.
📒 Files selected for processing (1)
packages/router-devtools-core/vite.config.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript in strict mode with extensive type safety across the codebase
Files:
packages/router-devtools-core/vite.config.ts
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR PR: TanStack/router#0 File: AGENTS.md:0-0 Timestamp: 2025-09-23T17:36:12.598Z Learning: Applies to packages/router-plugin/** : Use unplugin for universal bundler plugins in the router-plugin package🔇 Additional comments (1)
packages/router-devtools-core/vite.config.ts (1)
18-19: Good practice documenting the temporary workaround.The TODO comment clearly communicates the intent to refactor this into a cleaner solution within
@tanstack/config/vite. This aligns well with the PR description's stated follow-up plans.@@ -15,3 +15,18 @@1515 }),1616 )171718+// TODO: update tanstackViteConfig to expose the except option from vite-plugin-externalize-deps19+// so that we don't have to do this dance to bundle something20+merged.plugins.push(21+ {22+ name: 'vite-plugin-override-vite-plugin-externalize-deps',23+ config: (config) => {24+ const existing = config.build.rollupOptions.external;25+ config.build.rollupOptions.external = (id: string) => {26+ if (id === 'solid-js') return false;27+ return existing();28+ };29+ return config;30+ }31+ }32+)⚠️ Potential issue | 🔴 Critical
🧩 Analysis chain
Critical: Fix function parameter passing and verify module ID matching.
Two significant issues:
Line 27 calls
existing()without required arguments. Rollup'sexternalfunction signature is(id: string, parentId?: string, isResolved?: boolean) => boolean | null | void. The capturedexistingfunction expects these parameters, but your wrapper receivesidon line 25 and doesn't pass it through on line 27. This will break the existing externalization logic for all other modules.Line 26 only checks exact match
'solid-js', but the linked issue specifically mentions failing to resolve'solid-js/web'. Verify whether bundling the root package also bundles subpath imports, or if you needid.startsWith('solid-js')to cover all solid-js subpaths.
Additionally, the code lacks type safety (no annotations on
configorexisting) and doesn't defensively check whetherexistingis actually a function versus an array/regex pattern that Rollup also accepts.Apply this diff to fix the parameter passing:
const existing = config.build.rollupOptions.external; - config.build.rollupOptions.external = (id: string) => { + config.build.rollupOptions.external = (id: string, parentId?: string, isResolved?: boolean) => { if (id === 'solid-js') return false; - return existing(); + return typeof existing === 'function' + ? existing(id, parentId, isResolved) + : existing; };Then verify whether you need to change line 26 to handle subpaths:
if (id === 'solid-js' || id.startsWith('solid-js/')) return false;Run this script to confirm which solid-js imports are actually used in the source:
🏁 Script executed:
#!/bin/bash # Search for all solid-js imports in the router-devtools-core source rg --type=ts --type=tsx -n "from ['\"]solid-js" packages/router-devtools-core/src/Length of output: 27
🏁 Script executed:
#!/bin/bash # Search for imports from 'solid-js' or its subpaths in TS/TSX files rg -n "from ['\"]solid-js(/|')" -g "*.ts" -g "*.tsx" packages/router-devtools-coreLength of output: 2933
Preserve Rollup external signature and include
solid-jssubpaths- Pass-through all arguments to the original
externalhandler instead of callingexisting()with none. - Block both the root package and its subpaths (e.g.
solid-js/web) by matchingid === 'solid-js' || id.startsWith('solid-js/').
Example fix:
const existing = config.build.rollupOptions.external; config.build.rollupOptions.external = (id, importer?, isResolved?) => { if (id === 'solid-js' || id.startsWith('solid-js/')) return false; return typeof existing === 'function' ? existing(id, importer, isResolved) : existing; };🤖 Prompt for AI Agents
In packages/router-devtools-core/vite.config.ts around lines 20 to 32, the custom rollup external override calls existing() with no arguments and only checks the exact 'solid-js' id, which breaks the original external signature and misses subpaths; update the override to accept (id, importer?, isResolved?) and forward those arguments to the original external handler when it is a function, handle the case where existing is a non-function value by returning it directly, and change the check to return false for id === 'solid-js' || id.startsWith('solid-js/') so that both the root package and subpaths (e.g. 'solid-js/web') are blocked.Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/router-devtools-core/vite.config.ts (1)
18-20: Temporary workaround acknowledged.The TODO comment appropriately documents the intent to refactor this via
tanstackViteConfig. Given the urgency to unblock users, this interim approach is reasonable.Would you like me to open a tracking issue for the planned refactor to
@tanstack/config/vite?📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 30970808c5e472d8b91f058f6c382cc129e1b380 and 6049a0da27339a085e41915974e4bf7b9dc2066e.
📒 Files selected for processing (1)
packages/router-devtools-core/vite.config.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript in strict mode with extensive type safety across the codebase
Files:
packages/router-devtools-core/vite.config.ts
@@ -15,3 +15,16 @@1515 }),1616 )171718+// TODO: update tanstackViteConfig to expose the except option from vite-plugin-externalize-deps19+// so that we don't have to do this dance to bundle something20+merged.plugins.push({21+ name: 'vite-plugin-override-vite-plugin-externalize-deps',22+ config: (config) => {23+ const existing = config.build.rollupOptions.external24+ config.build.rollupOptions.external = (id: string) => {25+ if (id === 'solid-js') return false26+ return existing()27+ }28+ return config29+ },30+})⚠️ Potential issue | 🔴 Critical
Critical: Fix function signature and parameter passing.
The implementation has two critical issues:
Line 26:
existing()is called without arguments, but Rollup'sexternalfunction expects(source: string, importer: string | undefined, isResolved: boolean). This will cause incorrect externalization behavior.Line 25: The exact match check
id === 'solid-js'won't catch subpath imports like'solid-js/web'(which is explicitly mentioned in issue #5420). Useid.startsWith('solid-js')to cover all solid-js imports.
Apply this diff to fix both issues:
- config.build.rollupOptions.external = (id: string) => { - if (id === 'solid-js') return false - return existing() + config.build.rollupOptions.external = (id: string, importer?: string, isResolved?: boolean) => { + if (id.startsWith('solid-js')) return false + return existing(id, importer, isResolved) }📝 Committable suggestion
‼️ IMPORTANT Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
merged.plugins.push({ name: 'vite-plugin-override-vite-plugin-externalize-deps', config: (config) => { const existing = config.build.rollupOptions.external config.build.rollupOptions.external = (id: string, importer?: string, isResolved?: boolean) => { if (id.startsWith('solid-js')) return false return existing(id, importer, isResolved) } return config }, })🤖 Prompt for AI Agents
In packages/router-devtools-core/vite.config.ts around lines 20 to 30, the plugin's custom external function incorrectly checks only exact 'solid-js' equality and calls the existing external handler with no arguments; change the parameter list to (source: string, importer: string | undefined, isResolved: boolean), replace the exact check with source.startsWith('solid-js') so subpaths like 'solid-js/web' are handled, and when delegating to the previous external value call it with the same three parameters (e.g., return typeof existing === 'function' ? existing(source, importer, isResolved) : /* handle array/string case appropriately */) so the original behavior is preserved.More templates
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-solid-start-example-bare
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-static
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
@tanstack/arktype-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5422@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5422@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5422@tanstack/history
npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5422@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5422@tanstack/react-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5422@tanstack/react-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5422@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5422@tanstack/react-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5422@tanstack/react-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5422@tanstack/react-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5422@tanstack/router-cli
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5422@tanstack/router-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5422@tanstack/router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5422@tanstack/router-devtools-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5422@tanstack/router-generator
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5422@tanstack/router-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5422@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5422@tanstack/router-utils
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5422@tanstack/router-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5422@tanstack/server-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5422@tanstack/solid-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5422@tanstack/solid-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5422@tanstack/solid-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5422@tanstack/solid-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5422@tanstack/solid-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5422@tanstack/start-client-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5422@tanstack/start-plugin-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5422@tanstack/start-server-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5422@tanstack/start-static-server-functions
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5422@tanstack/start-storage-context
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5422@tanstack/valibot-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5422@tanstack/virtual-file-routes
npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5422@tanstack/zod-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5422commit:
5f4e2fcActionable comments posted: 1
🧹 Nitpick comments (1)
packages/router-devtools-core/vite.config.ts (1)
23-26: Consider handling non-function external types.Rollup's
externaloption accepts string, RegExp, arrays, or functions. IftanstackViteConfigcan ever setexternalto an array or regex, the early return will break that configuration. However, if this scenario is guaranteed never to occur (as suggested by the comment), the defensive check is acceptable.If you want to handle all external types robustly, apply this diff:
if (typeof config?.build?.rollupOptions?.external !== 'function') { - // this can never happen, but we need to make typescript happy - return + // If external is not a function, keep it as-is but still block solid-js + const staticExternal = config.build.rollupOptions.external + config.build.rollupOptions.external = (id: string) => { + if (id === 'solid-js' || id.startsWith('solid-js/')) return false + // staticExternal could be string, regex, or array - let Rollup handle it + return undefined // Let Rollup apply staticExternal pattern + } + return config }Otherwise, verify with the maintainers that
tanstackViteConfigalways sets a function and this branch is truly unreachable.📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 189b0df78e085f931c6333f1bdc003f1c2939858 and 7582b93a39865ad50c7283f36e04e743eb0a8a4a.
📒 Files selected for processing (1)
packages/router-devtools-core/vite.config.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript in strict mode with extensive type safety across the codebase
Files:
packages/router-devtools-core/vite.config.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
@@ -15,3 +15,19 @@1515 }),1616 )171718+// TODO: update tanstackViteConfig to expose the except option from vite-plugin-externalize-deps19+// so that we don't have to do this dance to bundle something20+merged.plugins.push({21+ name: 'vite-plugin-override-vite-plugin-externalize-deps',22+ config: (config: UserConfig) => {23+ if (typeof config?.build?.rollupOptions?.external !== 'function') {24+ // this can never happen, but we need to make typescript happy25+ return26+ }27+ const existing = config.build.rollupOptions.external28+ config.build.rollupOptions.external = (29+ id: string,30+ parentId?: string,31+ isResolved?: boolean,32+ ) => {33+ if (id === 'solid-js') return false⚠️ Potential issue | 🔴 Critical
Critical: Exact match will miss subpath imports like
'solid-js/web'.Issue #5420 explicitly reports a failure to resolve
"solid-js/web". Checking onlyid === 'solid-js'will not bundle subpath imports, leaving the reported issue unfixed.Apply this diff to bundle all solid-js subpaths:
- if (id === 'solid-js') return false + if (id === 'solid-js' || id.startsWith('solid-js/')) return false📝 Committable suggestion
‼️ IMPORTANT Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
const existing = config.build.rollupOptions.external; config.build.rollupOptions.external = ( id: string, importer?: string, isResolved?: boolean ) => { if (id === 'solid-js' || id.startsWith('solid-js/')) return false return typeof existing === 'function' ? existing(id, importer, isResolved) : existing; };🤖 Prompt for AI Agents
In packages/router-devtools-core/vite.config.ts around line 33, the current check "if (id === 'solid-js') return false" only matches the exact package name and misses subpath imports like "solid-js/web"; change the condition to also detect subpaths (for example by returning false when id === 'solid-js' OR id starts with 'solid-js/' or matches the package boundary) so all solid-js subpath imports are bundled as well.✅ Addressed in commit 833bc78
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 7582b93a39865ad50c7283f36e04e743eb0a8a4a and 186cfee77b9b015a9d723920071eeae91db666a0.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
package.json(1 hunks)packages/router-devtools-core/vite.config.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Use workspace:* protocol for internal dependencies in package.json files
Files:
package.json
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript in strict mode with extensive type safety across the codebase
Files:
packages/router-devtools-core/vite.config.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (1)
package.json (1)
41-41: @tanstack/config v0.21.0 upgrade is safe Confirmed support forbundledDeps, no security advisories, and no breaking changes impacting this usage.@@ -12,3 +12,4 @@1212 tanstackViteConfig({1313 entry: './src/index.tsx',1414 srcDir: './src',15+ bundledDeps: 'solid-js',⚠️ Potential issue | 🔴 Critical
🧩 Analysis chain
Verify that subpath imports like 'solid-js/web' are bundled.
Issue #5420 specifically reports failure to resolve
"solid-js/web". Please confirm that passingbundledDeps: 'solid-js'totanstackViteConfigwill bundle all solid-js subpath imports, not just the root package.
🏁 Script executed:
#!/bin/bash # Verify which solid-js imports are used in the source rg -n "from ['\"]solid-js" -g "*.ts" -g "*.tsx" packages/router-devtools-core/src/Length of output: 2933
🌐 Web query:
In @tanstack/config version 0.21.0, does the bundledDeps option for tanstackViteConfig bundle subpath imports? For example, if bundledDeps is set to 'solid-js', will it bundle both 'solid-js' and 'solid-js/web'?💡 Result:
Short answer: No — specify subpaths explicitly. BundledDeps in the TanStack Vite config is a package-name list (it marks packages to be bundled/treated as bundled dependencies); it does not implicitly expand a package name into its internal subpath imports (e.g. "solid-js/web"). If you need both the package root and a subpath to be bundled, include both "solid-js" and "solid-js/web" in the list. [1][2]
Sources:
- tanstack config (Vite) docs — tanstackViteConfig usage. [1]
- bundledDeps behavior (adds listed modules as bundled deps / dependency entries; list is package names — projen docs explaining bundledDeps semantics). [2]
Include subpath imports in bundledDeps Change
bundledDeps: 'solid-js'to an array including both root and subpath, e.g.:bundledDeps: ['solid-js', 'solid-js/web']This ensures imports from
solid-js/webare bundled.🤖 Prompt for AI Agents
In packages/router-devtools-core/vite.config.ts around line 15, bundledDeps is currently a single string 'solid-js' which omits subpath imports like 'solid-js/web'; update bundledDeps to an array containing both the root and needed subpaths (for example include 'solid-js' and 'solid-js/web') so imports from subpaths are recognized and bundled.✅ Addressed in commit 833bc78
why do we need to upgrade config? what does this version do that we need?
@schiller-manuel , I can see that the latest tanstack config has this change:
The issues that show up in the CI here are indeed unrelated to the PR. The errors show when bumping tanstack/config from 0.16.1 to 0.17.0 or higher on the main branch. @lachlancollins , I can see 0.17.1 move to TypeScirpt, but it appear much stricter already from 0.17.0 - do you know how that can be?
lachlancollins(GitHub profile, opens in a new tab) approved these changes
The issue was related to
vite-plugin-dts, which I've temporarily fixed to v4.0.3.birkskyum(GitHub profile, opens in a new tab) closed this
Sign in to join this conversation.
Important
Review skipped#
Review was skipped due to path filters
:no_entry: Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlCodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
**/dist/**will override the default block on thedistdirectory, by removing the pattern from both the lists.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.Walkthrough#
Adds bundling of
solid-jsandsolid-js/webby passingbundledDeps: ['solid-js', 'solid-js/web']into the tanstack Vite config forrouter-devtools-core, bumps devDependency@tanstack/configfrom^0.16.1to^0.21.0, and removes a// @ts-expect-errorcomment above an import ineslint.config.js. No exported API changes.Changes#
packages/router-devtools-core/vite.config.tsbundledDeps: ['solid-js', 'solid-js/web']to the merged call totanstackViteConfig, instructing the build to bundlesolid-jsandsolid-js/web.package.json@tanstack/configfrom^0.16.1to^0.21.0.eslint.config.js// @ts-expect-errordirective above the import oftanstackConfigfrom@tanstack/config/eslint; import remains unchanged.Sequence Diagram(s)#
Estimated code review effort#
🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs#
solid-jsin router-devtools-core packaging.Suggested reviewers#
Poem#
Pre-merge checks and finishing touches#
❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share