Skip to content
Source
Sign inSign up
TanStack/router

test(solid-start): serialization-adapters suite #5557

Mergedbirkskyum(GitHub profile, opens in a new tab)merged 33 commits intomain fromrefs/pull/5557/headmerged by birkskyum(GitHub profile, opens in a new tab)

Showing 25 changed files with 57 additions and 0 deletions (loading 20).

x
0 of 25 viewed, 25 left
20 additions and 0 deletionse2e/solid-start/serialization-adapters/.gitignoreAdded
View file
@@ -0,0 +1,20 @@
+node_modules
+package-lock.json
+yarn.lock
+​
+.DS_Store
+.cache
+.env
+.vercel
+.output
+/build/
+/api/
+/server/build
+/public/build# Sentry Config File
Thread on line 13

🛠️ Refactor suggestion | 🟠 Major

Fix formatting: separate pattern and comment.

The pattern /public/build and the comment # Sentry Config File are on the same line. This makes the comment ineffective and could be confusing.

-/public/build# Sentry Config File
+/public/build
+# Sentry Config File
📝 Committable suggestion

‼️ IMPORTANT Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

/public/build
# Sentry Config File
🤖 Prompt for AI Agents
In e2e/solid-start/serialization-adapters/.gitignore around line 13, the
gitignore entry combines the pattern "/public/build" and the comment "# Sentry
Config File" on the same line; split them so the ignore pattern stands alone on
its own line and the explanatory comment is on a separate line (e.g., move the
comment to the line above or below the pattern).
+.env.sentry-build-plugin
+/test-results/
+/playwright-report/
+/blob-report/
+/playwright/.cache/
+​