Skip to content
Source
Sign inSign up
TanStack/router

fix: solid start error outside monorepo #5566

Mergedbrenelz(GitHub profile, opens in a new tab)merged 1 commit intomain fromrefs/pull/5566/headmerged by brenelz(GitHub profile, opens in a new tab)

Summary by CodeRabbit

  • Refactor
    • Consolidated internal module imports to improve code organization and maintainability with no impact to user-facing functionality.
    1. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: solid-start

    2. Walkthrough

      Consolidates imports in the Solid Start client entry point, combining StartClient and hydrateStart imports from a unified module source (@tanstack/solid-start/client) instead of separate modules. No runtime behavior changes.

      Changes

      Cohort / File(s)Summary
      Import consolidation
      packages/solid-start/src/default-entry/client.tsx
      Unified StartClient and hydrateStart imports into a single module (@tanstack/solid-start/client), replacing separate imports from @tanstack/solid-start/client and @tanstack/start-client-core/client

      Estimated code review effort

      🎯 1 (Trivial) | ⏱️ ~3 minutes

      • TanStack/router#5521: Related through shared hydrateStart symbol; this PR consolidates its import location while the retrieved PR modifies its internal implementation in start-client-core.

      Suggested labels

      package: start-client-core

      Suggested reviewers

      • lachlancollins

      Poem

      🐰 With ears held high, I spot the way, One import path, no more delay! StartClient and hydrate unite, Consolidated code—oh what delight! ✨

      Pre-merge checks and finishing touches

      ✅ Passed checks (3 passed)
      Check nameStatusExplanation
      Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
      Title Check✅ PassedThe PR title "fix: solid start error outside monorepo" clearly describes the primary objective being addressed in the changeset. The code change—consolidating imports of StartClient and hydrateStart into a single module—directly implements a fix for the solid start error that occurs when the package is used outside a monorepo context. The title is specific and meaningful, accurately conveying what problem is being solved rather than just listing technical details. A teammate scanning the history would immediately understand that this PR addresses an issue with solid start's behavior in non-monorepo environments.
      Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
      ✨ Finishing touches
      • 📝 Generate docstrings
        🧪 Generate unit tests (beta)
      • Create PR with unit tests
      • Post copyable unit tests in a comment

      📜 Recent review details

      Configuration used: CodeRabbit UI

      Review profile: CHILL

      Plan: Pro

      📥 Commits

      Reviewing files that changed from the base of the PR and between 12f0e8c36a3ecd23a0b8a59f9dfb8b783d6ccdd5 and c05a708d0d8b50168a35a14dab06093f1b6a8921.

      📒 Files selected for processing (1)
      • packages/solid-start/src/default-entry/client.tsx (1 hunks)
      🧰 Additional context used
      📓 Path-based instructions (2)
      **/*.{ts,tsx}

      📄 CodeRabbit inference engine (AGENTS.md)

      Use TypeScript in strict mode with extensive type safety across the codebase

      Files:

      • packages/solid-start/src/default-entry/client.tsx
      packages/{*-start,start-*}/**

      📄 CodeRabbit inference engine (AGENTS.md)

      Name and place Start framework packages under packages/-start/ or packages/start-/

      Files:

      • packages/solid-start/src/default-entry/client.tsx
      ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
      • GitHub Check: Preview
      • GitHub Check: Test
      🔇 Additional comments (1)
      packages/solid-start/src/default-entry/client.tsx (1)

      2-2: Fix improves external resolution but consolidation is incomplete

      The consolidation in the default-entry file correctly resolves the external usage issue. However, the re-export chain through packages/solid-start-client/src/index.tsx still imports hydrateStart from @tanstack/start-client-core/client, which should also be consolidated for a complete fix.

      Recommended follow-up: Update packages/solid-start-client/src/index.tsx (line 2) to consolidate the hydrateStart import source, ensuring the entire stack uses consistent internal imports rather than spanning across separate package boundaries.

      The current fix works for external usage, but for full monorepo isolation and maintainability, both the default-entry and the underlying client package should use aligned import sources.


      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands and usage tips.
    3. View your CI Pipeline Execution ↗ for commit c05a708d0d8b50168a35a14dab06093f1b6a8921

      CommandStatusDurationResult
      nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded3m 28sView ↗
      nx run-many --target=build --exclude=examples/*...✅ Succeeded8sView ↗

      ☁️ Nx Cloud last updated this comment at 2025-10-21 14:13:33 UTC

    4. More templates

      @tanstack/arktype-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5566

      @tanstack/directive-functions-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5566

      @tanstack/eslint-plugin-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5566

      @tanstack/history

      npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5566

      @tanstack/nitro-v2-vite-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5566

      @tanstack/react-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5566

      @tanstack/react-router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5566

      @tanstack/react-router-ssr-query

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5566

      @tanstack/react-start

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5566

      @tanstack/react-start-client

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5566

      @tanstack/react-start-server

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5566

      @tanstack/router-cli

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5566

      @tanstack/router-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5566

      @tanstack/router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5566

      @tanstack/router-devtools-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5566

      @tanstack/router-generator

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5566

      @tanstack/router-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5566

      @tanstack/router-ssr-query-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5566

      @tanstack/router-utils

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5566

      @tanstack/router-vite-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5566

      @tanstack/server-functions-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5566

      @tanstack/solid-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5566

      @tanstack/solid-router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5566

      @tanstack/solid-router-ssr-query

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5566

      @tanstack/solid-start

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5566

      @tanstack/solid-start-client

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5566

      @tanstack/solid-start-server

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5566

      @tanstack/start-client-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5566

      @tanstack/start-plugin-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5566

      @tanstack/start-server-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5566

      @tanstack/start-static-server-functions

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5566

      @tanstack/start-storage-context

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5566

      @tanstack/valibot-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5566

      @tanstack/virtual-file-routes

      npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5566

      @tanstack/zod-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5566

      commit: c05a708

    5. birkskyum(GitHub profile, opens in a new tab) approved these changes

Sign in to join this conversation.