Skip to content
Source
Sign inSign up
TanStack/router

solid-start netlify vite plugin example #5575

Mergedbirkskyum(GitHub profile, opens in a new tab)merged 4 commits intomain fromrefs/pull/5575/headmerged by birkskyum(GitHub profile, opens in a new tab)

Showing 51 changed files with 10 additions and 0 deletions (loading 46).

x
0 of 51 viewed, 51 left
4 additions and 0 deletionsdocs/start/config.jsonModified
View file
@@ -329,6 +329,10 @@
"label": "Cloudflare Vite Plugin",
"to": "framework/solid/examples/start-basic-cloudflare"
+ },
+ {
+ "label": "Cloudflare Vite Plugin",
+ "to": "framework/solid/examples/start-basic-netlify"
Thread on lines 333 to 335

⚠️ Potential issue | 🟠 Major

Fix the incorrect label for the Netlify example.

The label says "Cloudflare Vite Plugin" but points to start-basic-netlify. This creates a duplicate label (line 330 already has "Cloudflare Vite Plugin") and misrepresents the example's purpose.

Apply this diff to correct the label:

             {
-              "label": "Cloudflare Vite Plugin",
+              "label": "Netlify Vite Plugin",
               "to": "framework/solid/examples/start-basic-netlify"
             }
📝 Committable suggestion

‼️ IMPORTANT Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

            {
              "label": "Netlify Vite Plugin",
              "to": "framework/solid/examples/start-basic-netlify"
🤖 Prompt for AI Agents
In docs/start/config.json around lines 333 to 335, the menu item incorrectly
uses the label "Cloudflare Vite Plugin" while linking to the Netlify example;
update the label to "Netlify" (or "Netlify Example"/"Netlify Adapter" per repo
convention) so it correctly describes the target and avoids duplicating the
Cloudflare label; keep the "to" value as
"framework/solid/examples/start-basic-netlify".
3 additions and 0 deletionsdocs/start/framework/react/guide/hosting.mdModified
View file
@@ -148,6 +148,9 @@