test(solid-router): update basic-file-based #5633
Merged
birkskyum(GitHub profile, opens in a new tab)merged 1 commit into
main fromrefs/pull/5633/head·merged by birkskyum(GitHub profile, opens in a new tab) run the dev server to generate route manifest etc
Summary by CodeRabbit#
- Chores
- Updated route path identifiers and corresponding declarations across test files to reflect revised naming conventions for file-based routing.
- Synchronized route type mappings and public declarations to align with restructured route identifiers.
- 1
View your CI Pipeline Execution ↗ for commit a944557a8eab7b6af40bea31abda1045279102c9
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded 3m 44s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 34s View ↗
☁️ Nx Cloud last updated this comment at
2025-10-26 13:55:45UTCMore templates
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-solid-start-example-bare
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
@tanstack/arktype-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5633@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5633@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5633@tanstack/history
npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5633@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5633@tanstack/react-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5633@tanstack/react-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5633@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5633@tanstack/react-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5633@tanstack/react-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5633@tanstack/react-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5633@tanstack/router-cli
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5633@tanstack/router-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5633@tanstack/router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5633@tanstack/router-devtools-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5633@tanstack/router-generator
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5633@tanstack/router-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5633@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5633@tanstack/router-utils
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5633@tanstack/router-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5633@tanstack/server-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5633@tanstack/solid-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5633@tanstack/solid-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5633@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5633@tanstack/solid-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5633@tanstack/solid-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5633@tanstack/solid-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5633@tanstack/start-client-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5633@tanstack/start-plugin-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5633@tanstack/start-server-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5633@tanstack/start-static-server-functions
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5633@tanstack/start-storage-context
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5633@tanstack/valibot-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5633@tanstack/virtual-file-routes
npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5633@tanstack/zod-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5633commit:
a944557birkskyum(GitHub profile, opens in a new tab) closed this
Sign in to join this conversation.
Walkthrough#
This PR updates route identifiers and file paths across Solid Router e2e test files to introduce trailing underscores in route names. The generated route tree (
routeTree.gen.ts) is updated to reflect new route IDs, path mappings, type definitions, and module augmentations. Individual route files are updated to use underscore-suffixed path strings in theircreateFileRoutedeclarations.Changes#
e2e/solid-router/basic-file-based/src/routeTree.gen.ts/posts/$postId/edit→/posts_/$postId/edit). Corresponding path/fullPath mappings adjusted. Public type declarations (FileRoutesByFullPath,FileRoutesByTo,FileRouteTypes) and module augmentations for@tanstack/solid-routerupdated to reflect new route keys and IDs.e2e/solid-router/basic-file-based/src/routes/non-nested/(named, path, prefix, suffix)/*createFileRoutedeclarations across four nested route files.e2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/*/params-ps/non-nested/$foo/...to/params-ps/non-nested/$foo_/...in route.tsx and $bar.tsx files.e2e/solid-router/basic-file-based/src/routes/posts_.$postId.edit.tsx/posts/$postId/editto/posts_/$postId/editwith conditional logic foruseExperimentalNonNestedRoutes.Estimated code review effort#
🎯 3 (Moderate) | ⏱️ ~20 minutes
routeTree.gen.ts: Comprehensive updates to route ID signatures, path mappings across multiple type definitions, and module augmentations require careful verification of consistency.posts_.$postId.edit.tsx: Contains conditional logic withuseExperimentalNonNestedRoutes; ensure the conditional path handling aligns with intended behavior.Possibly related PRs#
Suggested labels#
package: solid-routerSuggested reviewers#
Poem#
Pre-merge checks and finishing touches#
❌ Failed checks (1 warning, 1 inconclusive)
@coderabbitai generate docstringsto improve docstring coverage.✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between a65647b447a1b1b24a6aa049e766f24ea59de1aa and a944557a8eab7b6af40bea31abda1045279102c9.
📒 Files selected for processing (8)
e2e/solid-router/basic-file-based/src/routeTree.gen.ts(17 hunks)e2e/solid-router/basic-file-based/src/routes/non-nested/named/$baz_.bar.tsx(1 hunks)e2e/solid-router/basic-file-based/src/routes/non-nested/path/baz_.bar.tsx(1 hunks)e2e/solid-router/basic-file-based/src/routes/non-nested/prefix/prefix{$baz}_.bar.tsx(1 hunks)e2e/solid-router/basic-file-based/src/routes/non-nested/suffix/{$baz}suffix_.bar.tsx(1 hunks)e2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/$bar.tsx(1 hunks)e2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/route.tsx(1 hunks)e2e/solid-router/basic-file-based/src/routes/posts_.$postId.edit.tsx(1 hunks)🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/solid-router/basic-file-based/src/routes/non-nested/named/$baz_.bar.tsxe2e/solid-router/basic-file-based/src/routes/non-nested/prefix/prefix{$baz}_.bar.tsxe2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/$bar.tsxe2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/route.tsxe2e/solid-router/basic-file-based/src/routes/non-nested/path/baz_.bar.tsxe2e/solid-router/basic-file-based/src/routes/non-nested/suffix/{$baz}suffix_.bar.tsxe2e/solid-router/basic-file-based/src/routes/posts_.$postId.edit.tsxe2e/solid-router/basic-file-based/src/routeTree.gen.ts**/src/routes/**
📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/solid-router/basic-file-based/src/routes/non-nested/named/$baz_.bar.tsxe2e/solid-router/basic-file-based/src/routes/non-nested/prefix/prefix{$baz}_.bar.tsxe2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/$bar.tsxe2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/route.tsxe2e/solid-router/basic-file-based/src/routes/non-nested/path/baz_.bar.tsxe2e/solid-router/basic-file-based/src/routes/non-nested/suffix/{$baz}suffix_.bar.tsxe2e/solid-router/basic-file-based/src/routes/posts_.$postId.edit.tsxe2e/**
📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/solid-router/basic-file-based/src/routes/non-nested/named/$baz_.bar.tsxe2e/solid-router/basic-file-based/src/routes/non-nested/prefix/prefix{$baz}_.bar.tsxe2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/$bar.tsxe2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/route.tsxe2e/solid-router/basic-file-based/src/routes/non-nested/path/baz_.bar.tsxe2e/solid-router/basic-file-based/src/routes/non-nested/suffix/{$baz}suffix_.bar.tsxe2e/solid-router/basic-file-based/src/routes/posts_.$postId.edit.tsxe2e/solid-router/basic-file-based/src/routeTree.gen.ts🧠 Learnings (3)
📓 Common learnings
📚 Learning: 2025-09-22T00:56:49.237Z
Applied to files:
e2e/solid-router/basic-file-based/src/routes/non-nested/prefix/prefix{$baz}_.bar.tsxe2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/$bar.tsx📚 Learning: 2025-10-08T08:11:47.088Z
Applied to files:
e2e/solid-router/basic-file-based/src/routeTree.gen.ts🧬 Code graph analysis (7)
e2e/solid-router/basic-file-based/src/routes/non-nested/named/$baz_.bar.tsx (3)
e2e/solid-router/basic-file-based/src/routes/non-nested/prefix/prefix{$baz}_.bar.tsx (7)
e2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/$bar.tsx (4)
e2e/solid-router/basic-file-based/src/routes/params-ps/non-nested/$foo_/route.tsx (3)
e2e/solid-router/basic-file-based/src/routes/non-nested/path/baz_.bar.tsx (4)
e2e/solid-router/basic-file-based/src/routes/non-nested/suffix/{$baz}suffix_.bar.tsx (5)
e2e/solid-router/basic-file-based/src/routes/posts_.$postId.edit.tsx (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (24)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share