fix(solid-start): redirect from server function #5637
Merged
birkskyum(GitHub profile, opens in a new tab)merged 3 commits into
main fromrefs/pull/5637/head·merged by birkskyum(GitHub profile, opens in a new tab) test for
pass for react, fails for solid
Summary by CodeRabbit#
New Features
- Added redirect test routes and server-side redirect functionality to test environments
Tests
- Added end-to-end tests to verify redirect behavior during direct navigation
- Tests confirm successful redirect completion and proper URL updates across environments
- 1
View your CI Pipeline Execution ↗ for commit 76b9c9c7a445e5e0b96d08b8fb67d82e261b8f7c
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded 2m 28s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 1s View ↗
☁️ Nx Cloud last updated this comment at
2025-10-26 19:33:11UTCMore templates
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-solid-start-example-bare
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
@tanstack/arktype-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5637@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5637@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5637@tanstack/history
npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5637@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5637@tanstack/react-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5637@tanstack/react-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5637@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5637@tanstack/react-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5637@tanstack/react-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5637@tanstack/react-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5637@tanstack/router-cli
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5637@tanstack/router-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5637@tanstack/router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5637@tanstack/router-devtools-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5637@tanstack/router-generator
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5637@tanstack/router-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5637@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5637@tanstack/router-utils
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5637@tanstack/router-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5637@tanstack/server-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5637@tanstack/solid-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5637@tanstack/solid-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5637@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5637@tanstack/solid-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5637@tanstack/solid-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5637@tanstack/solid-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5637@tanstack/start-client-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5637@tanstack/start-plugin-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5637@tanstack/start-server-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5637@tanstack/start-static-server-functions
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5637@tanstack/start-storage-context
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5637@tanstack/valibot-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5637@tanstack/virtual-file-routes
npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5637@tanstack/zod-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5637commit:
76b9c9cbirkskyum(GitHub profile, opens in a new tab) closed this
Sign in to join this conversation.
Walkthrough#
Adds end-to-end test coverage for server-function redirects on direct navigation to both React and Solid start examples. Introduces
/redirect-test/and/redirect-test/targetroutes with server functions implementing redirect behavior, route tree regeneration, and corresponding UI components.Changes#
e2e/react-start/server-functions/src/routeTree.gen.tse2e/react-start/server-functions/src/routes/redirect-test/index.tsx,e2e/react-start/server-functions/src/routes/redirect-test/target.tsx/redirect-test/index (triggers server function that redirects to target) and/redirect-test/target(landing page after redirect); includes server function definition and Suspense-wrapped async renderinge2e/react-start/server-functions/tests/server-functions.spec.ts/redirect-testtriggers server-function redirect and lands on/redirect-test/targete2e/solid-start/server-functions/src/routeTree.gen.tse2e/solid-start/server-functions/src/routes/redirect-test/index.tsx,e2e/solid-start/server-functions/src/routes/redirect-test/target.tsx/redirect-test/index (with SSR data-only mode) and/redirect-test/target; implements server function redirect and query-based async renderinge2e/solid-start/server-functions/tests/server-functions.spec.tsSequence Diagram(s)#
Estimated code review effort#
🎯 3 (Moderate) | ⏱️ ~20 minutes
routeTree.gen.ts) accurately reflects new routes across both frameworksssr: 'data-only'mode) and async rendering patterns in React (Suspense boundary)Possibly related issues#
Suggested labels#
package: react-router,package: solid-routerSuggested reviewers#
Poem#
Pre-merge checks and finishing touches#
❌ Failed checks (2 warnings)
@coderabbitai generate docstringsto improve docstring coverage.✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 0bda974651634220ee68859d697f5be3a22cc18a and 76b9c9c7a445e5e0b96d08b8fb67d82e261b8f7c.
📒 Files selected for processing (8)
e2e/react-start/server-functions/src/routeTree.gen.ts(13 hunks)e2e/react-start/server-functions/src/routes/redirect-test/index.tsx(1 hunks)e2e/react-start/server-functions/src/routes/redirect-test/target.tsx(1 hunks)e2e/react-start/server-functions/tests/server-functions.spec.ts(1 hunks)e2e/solid-start/server-functions/src/routeTree.gen.ts(13 hunks)e2e/solid-start/server-functions/src/routes/redirect-test/index.tsx(1 hunks)e2e/solid-start/server-functions/src/routes/redirect-test/target.tsx(1 hunks)e2e/solid-start/server-functions/tests/server-functions.spec.ts(1 hunks)🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/solid-start/server-functions/tests/server-functions.spec.tse2e/react-start/server-functions/src/routes/redirect-test/index.tsxe2e/solid-start/server-functions/src/routes/redirect-test/target.tsxe2e/react-start/server-functions/src/routeTree.gen.tse2e/react-start/server-functions/tests/server-functions.spec.tse2e/react-start/server-functions/src/routes/redirect-test/target.tsxe2e/solid-start/server-functions/src/routes/redirect-test/index.tsxe2e/solid-start/server-functions/src/routeTree.gen.tse2e/**
📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/solid-start/server-functions/tests/server-functions.spec.tse2e/react-start/server-functions/src/routes/redirect-test/index.tsxe2e/solid-start/server-functions/src/routes/redirect-test/target.tsxe2e/react-start/server-functions/src/routeTree.gen.tse2e/react-start/server-functions/tests/server-functions.spec.tse2e/react-start/server-functions/src/routes/redirect-test/target.tsxe2e/solid-start/server-functions/src/routes/redirect-test/index.tsxe2e/solid-start/server-functions/src/routeTree.gen.ts**/src/routes/**
📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/react-start/server-functions/src/routes/redirect-test/index.tsxe2e/solid-start/server-functions/src/routes/redirect-test/target.tsxe2e/react-start/server-functions/src/routes/redirect-test/target.tsxe2e/solid-start/server-functions/src/routes/redirect-test/index.tsx🧬 Code graph analysis (4)
e2e/react-start/server-functions/src/routes/redirect-test/index.tsx (1)
e2e/solid-start/server-functions/src/routes/redirect-test/target.tsx (1)
e2e/react-start/server-functions/src/routes/redirect-test/target.tsx (1)
e2e/solid-start/server-functions/src/routes/redirect-test/index.tsx (1)
🔇 Additional comments (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share