test(solid-start): add missing custom-basepath tests #5641
Merged
birkskyum(GitHub profile, opens in a new tab)merged 1 commit into
main fromrefs/pull/5641/head·merged by birkskyum(GitHub profile, opens in a new tab) Summary by CodeRabbit#
New Features
- Added logout page with form-based user sign-out capability
- Added new redirect routes for testing client-side and server-side navigation flows
- Server function URLs now correctly include app basepath configuration for custom deployments
Tests
- Added end-to-end tests validating logout functionality, client-side redirects, and server-side redirect handling
Chores
- Removed unused imports from the posts detail page
- 1
View your CI Pipeline Execution ↗ for commit 4fc0f844038f4595b13a2deba5b626a0c21ecd6a
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded 1m 5s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 2s View ↗
☁️ Nx Cloud last updated this comment at
2025-10-26 22:15:24UTCMore templates
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-solid-start-example-bare
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
@tanstack/arktype-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5641@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5641@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5641@tanstack/history
npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5641@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5641@tanstack/react-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5641@tanstack/react-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5641@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5641@tanstack/react-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5641@tanstack/react-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5641@tanstack/react-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5641@tanstack/router-cli
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5641@tanstack/router-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5641@tanstack/router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5641@tanstack/router-devtools-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5641@tanstack/router-generator
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5641@tanstack/router-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5641@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5641@tanstack/router-utils
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5641@tanstack/router-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5641@tanstack/server-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5641@tanstack/solid-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5641@tanstack/solid-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5641@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5641@tanstack/solid-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5641@tanstack/solid-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5641@tanstack/solid-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5641@tanstack/start-client-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5641@tanstack/start-plugin-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5641@tanstack/start-server-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5641@tanstack/start-static-server-functions
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5641@tanstack/start-storage-context
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5641@tanstack/valibot-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5641@tanstack/virtual-file-routes
npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5641@tanstack/zod-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5641commit:
4fc0f84birkskyum(GitHub profile, opens in a new tab) closed this
Sign in to join this conversation.
Walkthrough#
The PR adds three new routes to a SolidStart e2e test application with custom basepath configuration: a logout route demonstrating server function URL handling, and two redirect routes showcasing client-side and server-side redirect patterns. The generated route tree and integration tests are updated accordingly.
Changes#
e2e/solid-start/custom-basepath/src/routes/logout.tsx,e2e/solid-start/custom-basepath/src/routes/redirect.index.tsx,e2e/solid-start/custom-basepath/src/routes/redirect.throw-it.tsxe2e/solid-start/custom-basepath/src/routeTree.gen.tse2e/solid-start/custom-basepath/src/routes/posts.$postId.tsxe2e/solid-start/custom-basepath/tests/navigation.spec.tsSequence Diagram(s)#
Estimated code review effort#
🎯 2 (Simple) | ⏱️ ~15 minutes
routeTree.gen.tsdoes not require detailed reviewposts.$postId.tsxis trivialPossibly related PRs#
Suggested labels#
package: solid-routerSuggested reviewers#
Poem#
Pre-merge checks and finishing touches#
❌ Failed checks (1 warning)
@coderabbitai generate docstringsto improve docstring coverage.✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 3b091d0c101415edbebec5abe553516357e1338c and 4fc0f844038f4595b13a2deba5b626a0c21ecd6a.
📒 Files selected for processing (6)
e2e/solid-start/custom-basepath/src/routeTree.gen.ts(12 hunks)e2e/solid-start/custom-basepath/src/routes/logout.tsx(1 hunks)e2e/solid-start/custom-basepath/src/routes/posts.$postId.tsx(2 hunks)e2e/solid-start/custom-basepath/src/routes/redirect.index.tsx(1 hunks)e2e/solid-start/custom-basepath/src/routes/redirect.throw-it.tsx(1 hunks)e2e/solid-start/custom-basepath/tests/navigation.spec.ts(1 hunks)🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/solid-start/custom-basepath/src/routes/redirect.throw-it.tsxe2e/solid-start/custom-basepath/src/routes/logout.tsxe2e/solid-start/custom-basepath/tests/navigation.spec.tse2e/solid-start/custom-basepath/src/routes/redirect.index.tsxe2e/solid-start/custom-basepath/src/routeTree.gen.tse2e/solid-start/custom-basepath/src/routes/posts.$postId.tsx**/src/routes/**
📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/solid-start/custom-basepath/src/routes/redirect.throw-it.tsxe2e/solid-start/custom-basepath/src/routes/logout.tsxe2e/solid-start/custom-basepath/src/routes/redirect.index.tsxe2e/solid-start/custom-basepath/src/routes/posts.$postId.tsxe2e/**
📄 CodeRabbit inference engine (AGENTS.md)
Files:
e2e/solid-start/custom-basepath/src/routes/redirect.throw-it.tsxe2e/solid-start/custom-basepath/src/routes/logout.tsxe2e/solid-start/custom-basepath/tests/navigation.spec.tse2e/solid-start/custom-basepath/src/routes/redirect.index.tsxe2e/solid-start/custom-basepath/src/routeTree.gen.tse2e/solid-start/custom-basepath/src/routes/posts.$postId.tsx🧬 Code graph analysis (4)
e2e/solid-start/custom-basepath/src/routes/redirect.throw-it.tsx (1)
e2e/solid-start/custom-basepath/src/routes/logout.tsx (3)
e2e/solid-start/custom-basepath/src/routes/redirect.index.tsx (2)
e2e/solid-start/custom-basepath/src/routeTree.gen.ts (1)
🔇 Additional comments (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share