agents #8258
main fromrefs/pull/8258/headmerged by schiller-manuel(GitHub profile, opens in a new tab) github-actions[bot](GitHub profile, opens in a new tab) added labelsdocumentation
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-plugin
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-generator
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: history
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-plugin-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-server-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-client-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-ssr-query-core
- e2e/AGENTS.md line 3@@ -0,0 +1,3 @@1+# E2E tests2+3+Read the project's `package.json` and test config. Inspect resolved targets with `CI=1 NX_DAEMON=false pnpm nx show project <name> --json`: `nx.metadata.playwrightModes` generates modes, variants, and shards. The aggregate `test:e2e` can also run extra package-script suites. For focused Playwright runs, select an executable test target (a mode/shard target when inferred) and append filters after `--` (e.g. `-- tests/navigation.spec.ts --grep "redirect"`).
- packages/router-core/AGENTS.md line 8@@ -0,0 +1,8 @@1+# Router core2+3+`RouterCore.update` gates shared route-tree caching with `process.env.NODE_ENV !== 'development'`. `loadRouteChunk` checks promise ownership outside production so obsolete lazy imports cannot overwrite HMR changes. Preserve both behaviors; validate hot updates while imports are pending.4+Route hooks, lifecycle callbacks, and abort listeners can navigate synchronously. Recheck the internal navigation owner after callbacks and awaits before publishing state/assets. Public loader abort signals belong to shared data generations; self-aborting a loader does not discard its result or error. Preserve loader ownership when transferring work between preload, navigation, cache, and background loads; see [`tests/preload-public-signal-lifetime.test.ts`](tests/preload-public-signal-lifetime.test.ts).5+Reusing loader work/data does not reuse `beforeLoad`: each active preload and subsequent navigation reruns it. Keep its returned context separate from reusable route-context contributions; see [`tests/public-preload-lane-contract.test.ts`](tests/public-preload-lane-contract.test.ts).6+Code emitted into HTML (`?script-string` entries and RawStream factories) executes without module scope. Keep it self-contained; pass dependencies explicitly. Validate emitted strings through the existing execution tests after refactors (`RawStream`, `scroll-restoration-script`, `tsr-script-teardown`).7+Before changing SSR streaming or hydration transport, read [`src/ssr/STREAMING.md`](src/ssr/STREAMING.md). Byte ordering, renderer safe points, and completion handling have framework-specific contracts.8+Backpressure tests are excluded from normal unit runs. For buffering/backpressure changes, run the gated suite below. Its memory case requires exposed GC; bypass Nx cache so a previous run with the gate disabled cannot count as validation.
Sign in to join this conversation.
Caution
Review failed#
The pull request is closed.
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID:
f943e4b5-d5be-402f-a593-61fa4bd10707📥 Commits
Reviewing files that changed from the base of the PR and between ce1aab4e1d119927e9233a9d1774979285f1801d and 863b87be6977e20244b9bf8ce7263a1e05f2ade1.
📒 Files selected for processing (1)
AGENTS.md📝 Walkthrough
Walkthrough#
The pull request replaces general contributor guidance with focused agent instructions. It adds scoped guidance for repository workflows, benchmarks, documentation, E2E tests, examples, router packages, and Start runtime packages.
Changes#
Repository Guidance
AGENTS.md,docs/AGENTS.md,e2e/AGENTS.md,examples/AGENTS.mdAGENTS.md,benchmarks/AGENTS.mdpackages/AGENTS.md,packages/history/AGENTS.md,packages/router-core/AGENTS.md,packages/router-generator/AGENTS.md,packages/router-plugin/AGENTS.md,packages/router-ssr-query-core/AGENTS.mdpackages/start-client-core/AGENTS.md,packages/start-plugin-core/AGENTS.md,packages/start-server-core/AGENTS.mdEstimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Suggested reviewers:
sheraffMerge Risk: 🔵 Low · up to
07d86This documentation-only change adds agent workflows, but one mandatory bundle-validation link is unusable and one router-core instruction remains unclear. These issues do not affect runtime behavior, but should be corrected so contributors can reliably follow the intended validation guidance.
🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)#
✅ Passed checks (3 passed)
Full details: Description check
Resolution
Add a description that completes the template, including the change summary and motivation, checklist status, relevant test commands or justification, AI-assisted code understanding confirmation, and whether the change is documentation/dev-only or requires a changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share