update generated route trees #8841
main fromrefs/pull/8841/head·merged by schiller-manuel(GitHub profile, opens in a new tab) Summary by CodeRabbit#
- Chores
- Reordered routes in benchmark examples. Route paths, behavior, and metadata remain unchanged.
- 1
Codex Review Summary#
This comment shows the latest Codex review activity on this pull request.
Review Status Commit Review trigger 🔒 Security Review ✅ Completed 2026-11-01T22:33:12.134893Z 71b0a43PR opened ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
No actionable comments were generated in the recent review.
Recent review info-
Run configuration-
- Source mode: Auto
- Repository: TanStack/router
- Branch: update-route-trees
- File: .coderabbit.yaml
- Commit: 71b0a43
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
32449a94-8286-4f70-b41c-29390cfd0a9e
Commits-
Reviewing files that changed from the base of the PR and between da2adec76dbe6c0da6d6a0d5640f7b9388217f45 and 71b0a43a82483784213a8132dc5749d1312eeea0.
Files selected for processing: 14-
benchmarks/client-nav/scenarios/async-pipeline/solid/src/routeTree.gen.tsbenchmarks/client-nav/scenarios/control-flow/solid/src/routeTree.gen.tsbenchmarks/client-nav/scenarios/head/solid/src/routeTree.gen.tsbenchmarks/client-nav/scenarios/history/solid/src/routeTree.gen.tsbenchmarks/client-nav/scenarios/links/solid/src/routeTree.gen.tsbenchmarks/client-nav/scenarios/loaders/solid/src/routeTree.gen.tsbenchmarks/client-nav/scenarios/mount/solid/src/routeTree.gen.tsbenchmarks/client-nav/scenarios/preload/solid/src/routeTree.gen.tsbenchmarks/client-nav/scenarios/route-tree-scale/solid/src/routeTree.gen.tsbenchmarks/client-nav/scenarios/search-params/solid/src/routeTree.gen.tsbenchmarks/ssr/scenarios/control-flow/solid/src/routeTree.gen.tsbenchmarks/ssr/scenarios/global-middleware/solid/src/routeTree.gen.tsbenchmarks/ssr/scenarios/serialization/solid/src/routeTree.gen.tsbenchmarks/ssr/scenarios/server-fns/solid/src/routeTree.gen.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
-
Walkthrough
-
The generated Solid route trees in client-navigation and SSR benchmarks now use reordered route declarations and
FileRoutesByPathentries. Route IDs, paths, parent relationships, and route associations remain unchanged.Changes: Solid benchmark route trees
Layer / File(s) Summary Client-navigation route ordering
benchmarks/client-nav/scenarios/*/solid/src/routeTree.gen.tsRoute imports, initialization declarations, and FileRoutesByPathentries are reordered across the client-navigation scenarios. Route metadata remains unchanged.SSR route ordering
benchmarks/ssr/scenarios/*/solid/src/routeTree.gen.tsRoute imports, definitions, and FileRoutesByPathentries are reordered across the SSR scenarios. Route metadata remains unchanged.Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Suggested labels:
package: router-generatorSuggested reviewers:
sheraff
Merge Risk:
Minimal · up to71b0a-
No actionable merge-blocking risk was identified in the route-tree updates.
Pre-merge checks:
4 · 1-
Failed checks: 1 warningCheck name Status Explanation Resolution Description check No pull request description was provided. Required change details, checklist responses, and release impact information are missing. Add a description that follows the repository template. Summarize the generated route tree updates, complete the checklist, and indicate whether the change requires a changeset or is dev-only. Passed checks: 4 passed-
Check name Status Explanation Title check The title clearly and concisely describes the main change: updating generated route trees. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 14 files.
-
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
-
View your CI Pipeline Execution ↗ for commit 71b0a43a82483784213a8132dc5749d1312eeea0
Command Status Duration Result nx run-many --target=build --exclude=examples/*...✅ Succeeded 1m 25s View ↗ nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded <1s View ↗
☁️ Nx Cloud last updated this comment at
2026-11-01 22:34:35UTC🚀 Changeset Version Preview#
No changeset entries found. Merging this PR will not cause a version bump for any packages.
Bundle Size Benchmarks#
This pull request does not affect bundle size in any measured scenario.
More templates
- tanstack-router-solid-example-authenticated-routes
- tanstack-router-solid-example-authenticated-routes-firebase
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-default-search-params
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-basic-virtual-file-based
- tanstack-router-solid-example-basic-virtual-inside-file-based
- tanstack-router-solid-example-deferred-data
- tanstack-router-solid-i18n-paraglide
- tanstack-router-solid-example-kitchen-sink
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-large-file-based
- tanstack-router-solid-example-location-masking
- tanstack-router-solid-example-navigation-blocking
- tanstack-router-solid-example-quickstart
- tanstack-router-solid-example-quickstart-esbuild-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-router-solid-example-quickstart-rspack-file-based
- tanstack-router-solid-example-quickstart-webpack-file-based
- @tanstack/router-solid-mono-simple
- router-solid-mono-simple-lazy
- router-solid-monorepo-solid-query
- tanstack-router-solid-example-scroll-restoration
- tanstack-solid-router-search-validator-adapters
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-authjs
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
- tanstack-solid-start-bun-hosting
- tanstack-solid-start-example-convex-better-auth
- tanstack-solid-start-example-counter
- tanstack-solid-start-i18n-paraglide
- tanstack-solid-start-example-large
- tanstack-solid-start-streaming-data-from-server-functions
- tanstack-solid-start-example-supabase-basic
- tanstack-solid-start-tailwind-v4
- tanstack-router-solid-example-view-transitions
- tanstack-router-solid-example-with-framer-motion
- tanstack-router-solid-example-with-trpc
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-router-react-example-basic-authjs
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-rsbuild
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-example-next-migration
- tanstack-start-example-rscs
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
- tanstack-router-vue-example-basic-jsx
- tanstack-router-vue-example-basic-file-based-jsx
- tanstack-router-vue-example-basic-file-based-sfc
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8841@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8841@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8841@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8841@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8841@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8841@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8841@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8841@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8841@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8841@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8841@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8841@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8841@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8841@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8841@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8841@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8841@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8841@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8841@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8841@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8841@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8841@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8841@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8841@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8841@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8841@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8841@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8841@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8841@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8841@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8841@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8841@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8841@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8841@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8841@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8841@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8841@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8841@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8841@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8841@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8841commit:
71b0a43Merging this PR will regress 1 benchmark#
2 warnings
:warning: 48 benchmarks are dominated by system calls
System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.
:warning: 1 benchmark with a significant change ran on different hardware
Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.
⚡ 2improved benchmarks❌ 1regressed benchmark✅ 191untouched benchmarks⏩ 3skipped benchmarks1Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes#
Mode Benchmark BASEHEADEfficiency ❌ Memory mem server error-paths error (vue)131.2 KB 136.8 KB -4.09% ⚡ Memory mem client interrupted-navigations (vue)99.8 KB 94 KB +6.11% ⚡ Memory mem client navigation-churn (solid)109.7 KB 105.6 KB +3.89% Tip
Investigate this regression by commenting
@codspeedbot fix this regressionon this PR, or directly use the CodSpeed MCP with your agent.
Comparingupdate-route-trees(71b0a43) withmain(da2adec)Footnotes#
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
Sign in to join this conversation.
⚠️ No Changeset found#
Latest commit: 71b0a43a82483784213a8132dc5749d1312eeea0
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR