Skip to content
Source
Sign inSign up
TanStack/router

update generated route trees #8841

Mergedschiller-manuel(GitHub profile, opens in a new tab)merged 1 commit intomain fromrefs/pull/8841/headmerged by schiller-manuel(GitHub profile, opens in a new tab)

Summary by CodeRabbit

  • Chores
    • Reordered routes in benchmark examples. Route paths, behavior, and metadata remain unchanged.
    1. ⚠️ No Changeset found

      Latest commit: 71b0a43a82483784213a8132dc5749d1312eeea0

      Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

      This PR includes no changesets

      When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

      Click here to learn what changesets are, and how to add one.

      Click here if you're a maintainer who wants to add a changeset to this PR

    2. Codex Review Summary

      This comment shows the latest Codex review activity on this pull request.

      ReviewStatusCommitReview trigger
      🔒 Security Review✅ Completed 2026-11-01T22:33:12.134893Z71b0a43PR opened
      ℹ️ About Codex in GitHub

      Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

      • Open a pull request for review
      • Mark a draft as ready
      • Comment "@codex review" or "@codex security review".

      Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

    3. Review in Change Stack →

      No actionable comments were generated in the recent review.

      Recent review info
      Run configuration
      Commits

      Reviewing files that changed from the base of the PR and between da2adec76dbe6c0da6d6a0d5640f7b9388217f45 and 71b0a43a82483784213a8132dc5749d1312eeea0.

      Files selected for processing: 14
      • benchmarks/client-nav/scenarios/async-pipeline/solid/src/routeTree.gen.ts
      • benchmarks/client-nav/scenarios/control-flow/solid/src/routeTree.gen.ts
      • benchmarks/client-nav/scenarios/head/solid/src/routeTree.gen.ts
      • benchmarks/client-nav/scenarios/history/solid/src/routeTree.gen.ts
      • benchmarks/client-nav/scenarios/links/solid/src/routeTree.gen.ts
      • benchmarks/client-nav/scenarios/loaders/solid/src/routeTree.gen.ts
      • benchmarks/client-nav/scenarios/mount/solid/src/routeTree.gen.ts
      • benchmarks/client-nav/scenarios/preload/solid/src/routeTree.gen.ts
      • benchmarks/client-nav/scenarios/route-tree-scale/solid/src/routeTree.gen.ts
      • benchmarks/client-nav/scenarios/search-params/solid/src/routeTree.gen.ts
      • benchmarks/ssr/scenarios/control-flow/solid/src/routeTree.gen.ts
      • benchmarks/ssr/scenarios/global-middleware/solid/src/routeTree.gen.ts
      • benchmarks/ssr/scenarios/serialization/solid/src/routeTree.gen.ts
      • benchmarks/ssr/scenarios/server-fns/solid/src/routeTree.gen.ts

      Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

      Walkthrough

      The generated Solid route trees in client-navigation and SSR benchmarks now use reordered route declarations and FileRoutesByPath entries. Route IDs, paths, parent relationships, and route associations remain unchanged.

      Changes: Solid benchmark route trees

      Layer / File(s)Summary
      Client-navigation route ordering
      benchmarks/client-nav/scenarios/*/solid/src/routeTree.gen.ts
      Route imports, initialization declarations, and FileRoutesByPath entries are reordered across the client-navigation scenarios. Route metadata remains unchanged.
      SSR route ordering
      benchmarks/ssr/scenarios/*/solid/src/routeTree.gen.ts
      Route imports, definitions, and FileRoutesByPath entries are reordered across the SSR scenarios. Route metadata remains unchanged.

      Estimated code review effort: 2 (Simple) | ~10 minutes

      Change: Other

      Suggested labels: package: router-generator

      Suggested reviewers: sheraff

      Merge Risk: Minimal · up to 71b0a

      No actionable merge-blocking risk was identified in the route-tree updates.

      Pre-merge checks: Passed 4 · Failed 1
      Failed Failed checks: 1 warning
      Check nameStatusExplanationResolution
      Description checkWarningNo pull request description was provided. Required change details, checklist responses, and release impact information are missing.Add a description that follows the repository template. Summarize the generated route tree updates, complete the checklist, and indicate whether the change requires a changeset or is dev-only.
      Passed Passed checks: 4 passed
      Check nameStatusExplanation
      Title checkPassedThe title clearly and concisely describes the main change: updating generated route trees.
      Docstring CoveragePassedNo eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
      Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
      Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
      Full details: Docstring Coverage

      Explanation

      No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 14 files.

      Finishing Touches
      Generate docstrings
      • Commit to this branch
      • Create a new PR
      Generate unit tests (beta)
      • Commit to this branch
      • Create a new PR
      • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      Share
    4. View your CI Pipeline Execution ↗ for commit 71b0a43a82483784213a8132dc5749d1312eeea0

      CommandStatusDurationResult
      nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 25sView ↗
      nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded<1sView ↗

      ☁️ Nx Cloud last updated this comment at 2026-11-01 22:34:35 UTC

    5. 🚀 Changeset Version Preview

      No changeset entries found. Merging this PR will not cause a version bump for any packages.

    6. Bundle Size Benchmarks

      This pull request does not affect bundle size in any measured scenario.

    7. More templates

      @tanstack/arktype-adapter

      npm i https://pkg.pr.new/@tanstack/arktype-adapter@8841

      @tanstack/eslint-plugin-router

      npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8841

      @tanstack/eslint-plugin-start

      npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8841

      @tanstack/history

      npm i https://pkg.pr.new/@tanstack/history@8841

      @tanstack/react-router

      npm i https://pkg.pr.new/@tanstack/react-router@8841

      @tanstack/react-router-devtools

      npm i https://pkg.pr.new/@tanstack/react-router-devtools@8841

      @tanstack/react-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8841

      @tanstack/react-start

      npm i https://pkg.pr.new/@tanstack/react-start@8841

      @tanstack/react-start-client

      npm i https://pkg.pr.new/@tanstack/react-start-client@8841

      @tanstack/react-start-rsc

      npm i https://pkg.pr.new/@tanstack/react-start-rsc@8841

      @tanstack/react-start-server

      npm i https://pkg.pr.new/@tanstack/react-start-server@8841

      @tanstack/router-cli

      npm i https://pkg.pr.new/@tanstack/router-cli@8841

      @tanstack/router-core

      npm i https://pkg.pr.new/@tanstack/router-core@8841

      @tanstack/router-devtools

      npm i https://pkg.pr.new/@tanstack/router-devtools@8841

      @tanstack/router-devtools-core

      npm i https://pkg.pr.new/@tanstack/router-devtools-core@8841

      @tanstack/router-generator

      npm i https://pkg.pr.new/@tanstack/router-generator@8841

      @tanstack/router-plugin

      npm i https://pkg.pr.new/@tanstack/router-plugin@8841

      @tanstack/router-ssr-query-core

      npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8841

      @tanstack/router-utils

      npm i https://pkg.pr.new/@tanstack/router-utils@8841

      @tanstack/router-vite-plugin

      npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8841

      @tanstack/solid-router

      npm i https://pkg.pr.new/@tanstack/solid-router@8841

      @tanstack/solid-router-devtools

      npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8841

      @tanstack/solid-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8841

      @tanstack/solid-start

      npm i https://pkg.pr.new/@tanstack/solid-start@8841

      @tanstack/solid-start-client

      npm i https://pkg.pr.new/@tanstack/solid-start-client@8841

      @tanstack/solid-start-server

      npm i https://pkg.pr.new/@tanstack/solid-start-server@8841

      @tanstack/start-client-core

      npm i https://pkg.pr.new/@tanstack/start-client-core@8841

      @tanstack/start-fn-stubs

      npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8841

      @tanstack/start-plugin-core

      npm i https://pkg.pr.new/@tanstack/start-plugin-core@8841

      @tanstack/start-server-core

      npm i https://pkg.pr.new/@tanstack/start-server-core@8841

      @tanstack/start-static-server-functions

      npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8841

      @tanstack/start-storage-context

      npm i https://pkg.pr.new/@tanstack/start-storage-context@8841

      @tanstack/valibot-adapter

      npm i https://pkg.pr.new/@tanstack/valibot-adapter@8841

      @tanstack/virtual-file-routes

      npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8841

      @tanstack/vue-router

      npm i https://pkg.pr.new/@tanstack/vue-router@8841

      @tanstack/vue-router-devtools

      npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8841

      @tanstack/vue-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8841

      @tanstack/vue-start

      npm i https://pkg.pr.new/@tanstack/vue-start@8841

      @tanstack/vue-start-client

      npm i https://pkg.pr.new/@tanstack/vue-start-client@8841

      @tanstack/vue-start-server

      npm i https://pkg.pr.new/@tanstack/vue-start-server@8841

      @tanstack/zod-adapter

      npm i https://pkg.pr.new/@tanstack/zod-adapter@8841

      commit: 71b0a43

    8. Merging this PR will regress 1 benchmark

      2 warnings

      :warning: 48 benchmarks are dominated by system calls

      System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

      Learn more about system calls

      See affected benchmarks

      :warning: 1 benchmark with a significant change ran on different hardware

      Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

      Learn more about Macro Runners

      See affected benchmarks

      ⚡ 2 improved benchmarks ❌ 1 regressed benchmark ✅ 191 untouched benchmarks ⏩ 3 skipped benchmarks1

      Warning

      Please fix the performance issues or acknowledge them on CodSpeed.

      Performance Changes

      ModeBenchmarkBASEHEADEfficiency
      ❌Memorymem server error-paths error (vue)131.2 KB136.8 KB-4.09%
      ⚡Memorymem client interrupted-navigations (vue)99.8 KB94 KB+6.11%
      ⚡Memorymem client navigation-churn (solid)109.7 KB105.6 KB+3.89%

      Tip

      Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


      Comparing update-route-trees (71b0a43) with main (da2adec) Open in CodSpeed

      Footnotes

      1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign in to join this conversation.