Skip to content
Source
Sign inSign up
TanStack/schemas

Clear a docs-failing row when an adapter stops reporting docs failures #678

Mergedtombeckenhammerged 1 commit intomain fromrefs/pull/678/headmerged by tombeckenham View on GitHub

tombeckenhamcommented

Fixes #677.

pollProviderModels only called recordDocsFailing when listModels returned docsFailures. OpenCode Go after #676 returns { models } with that field omitted, so the docs-failing:opencode-go row from the earlier outage stayed on GET /v1/status and the home page.

A completed poll with no docsFailures is now a healthy docs run: it deletes the row the same way a zero report does. A skipped listing still returns before that and leaves the record. Adapters that report failures are unchanged.

    1. ⚠️ No Changeset found

      Latest commit: 383901ac1be0840fb3aab79a605970badf3f13db

      Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

      This PR includes no changesets

      When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

      Click here to learn what changesets are, and how to add one.

      Click here if you're a maintainer who wants to add a changeset to this PR

    2. Warning

      Review limit reached

      You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

      Next included review available in 7 minutes.

      Check out review usage here.

      View limit details

      Limit details: You’ve used the included review currently available.

      Learn how review limits work.

      Review configuration:

      Run configuration

      • Source mode: Auto
      • Repository: Unavailable
      • Branch: Unavailable
      • File: No configuration file from this repository applied
      • Commit: Unavailable
      • Layers: defaults
      • Review profile: CHILL
      • Plan: Advanced
      • Run ID: cddbe4b8-9520-497a-827a-586c117163e2
      Commits

      Reviewing files that changed from the base of the PR and between 044efb3a1d494a1e385d6a8bda1e97508e71b223 and 383901ac1be0840fb3aab79a605970badf3f13db.

      Files selected for processing: 5

      • README.md
      • src/server/ingest/docs-absent-recovery.worker.test.ts
      • src/server/ingest/docs-failing.ts
      • src/server/ingest/poll-models.ts
      • src/server/providers/types.ts
      • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      Share

    3. tombeckenham linked this to fix #677

    4. tanstack-source added labelsbug

    5. tombeckenham merged this9153af1

    6. tombeckenham closed this

Sign in to join this conversation.