fireworks: state the upstream model from each model's huggingFaceUrl #753 (GitHub #752)
main fromfeat/718-upstream-fireworks·merged by tombeckenham View on GitHubPart of #718.
The field#
Fireworks' OpenAI-compatible listing (GET /inference/v1/models, 31 live rows on 2026-11-21) names no maker: its fields are id, object, owned_by, created, kind, supports_chat, supports_image_input, supports_tools, context_length, and owned_by is fireworks on every row. The maker statement is huggingFaceUrl in each model's native metadata (GET https://api.fireworks.ai/v1/<rawId>). https://huggingface.co/<owner>/<name> is stored as namespace <owner>, raw id <name>, with factSources.sameAs = { derivation: 'listing', sourceUrl: <that metadata URL>, path: 'huggingFaceUrl' }.
Live, with the key: 19 of the 31 listed rows are accounts/fireworks/models/* (the other 12 are accounts/fireworks/routers/*, auto and firerouter/auto, which read no metadata). All 19 answered 200; 17 carry a repo URL, 2 are empty (ember-1, Fireworks' own, and qwen3-reranker-8b) and state nothing. Trimmed real fixture: src/server/providers/fixtures/fireworks-native-models.json.
Cost#
The adapter already read this metadata, but only for chat rows with no stated reasoning. It now reads it for every model row, through the same tryDocs + cachedDocs path (6-hour TTL, failure budget). Cold poll: 19 requests (was a subset of those). Warm poll: 0. Cache key is <url>#native, because the old <url> entry held { supported, hash } only; docs-cache-keys.test.ts passes.
Failures#
A failed load marks the row absent.upstream: 'unavailable' (plus capabilities when the row would have read reasoning). upstream is a new ModelFact: unavailable keeps the stored evidence, and cleared writes null. An unreadable huggingFaceUrl throws. Fireworks' account catalogue has 4 such values on models it does not list today (.../tree/main, owner-only https://huggingface.co/Qwen/).
Links#
These rows state an upstream, and 2 link. In SQL, namespace and raw id match case-sensitively:
- Link:
minimax-m3→MiniMaxAI/MiniMax-M3→minimax/MiniMax-M3, andminimax-m3p1-flash→minimax/MiniMax-M3.1-Flash(the dots-as-hyphens tier). - Claimed namespace, but no exact id:
moonshotai/Kimi-K3andKimi-K3.1-Pro(moonshot listskimi-k3),zai-org/GLM-5.3andGLM-5.3-Flash(zai listsglm-5.3),openai/gpt-oss-120b(not in openai's catalogue), and 2nvidia/NVIDIA-Nemotron-*repos. - Unclaimed namespace:
Qwen(dashscope claims lowercaseqwen),deepseek-ai(twice),thinkingmachines,meta-models,surogate(a GGUF re-upload).
Case-insensitive matching would link the 4 Kimi/GLM rows. That is a change to reconcileSameAs that affects every provider, so it is left for a separate PR. This PR adds no namespace claims.
Name tier#
There is no effect. originNameKey('accounts/fireworks/models/x') keeps the accounts/... prefix, because accounts is no provider or namespace, so no Fireworks row can match by name. The live catalogue agrees: 0 of 46 Fireworks rows have sameAs today. Stating evidence therefore removes no name-inferred link.
Self evidence#
A Fireworks-made model states nothing: ember-1 has an empty field. Fireworks' own HF org is fireworks-ai (firefunction-v1/v2, both unlisted). fireworks-ai is not claimed, so if such a row is listed it would store unresolved evidence. That is harmless because these ids cannot link by name.
- 1
Warning
Review limit reached#
You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.
Next included review available in 39 minutes.
View limit details
-
Limit details: You’ve used the included review currently available.
Review configuration:
Run configuration-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
5bfbd9ea-195e-4f61-b0a7-1768c4b5084a
Commits-
Reviewing files that changed from the base of the PR and between c786176804df7380e6f02a539f6479b5354121a4 and b8a5ba587b37175b1c03e83e02569573e1be0644.
Files selected for processing: 9-
CLAUDE.mdsrc/server/ingest/model-identity.worker.test.tssrc/server/ingest/poll-models.tssrc/server/providers/adapters/fireworks.test.tssrc/server/providers/adapters/fireworks.tssrc/server/providers/fixtures/fireworks-native-models.jsonsrc/server/providers/host-native-reasoning.test.tssrc/server/providers/native-host-reasoning.tssrc/server/providers/types.ts
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
-
tombeckenham merged this41251c7
tombeckenham closed this
Sign in to join this conversation.
⚠️ No Changeset found#
Latest commit: b8a5ba587b37175b1c03e83e02569573e1be0644
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR