Skip to content
Source
Sign inSign up
TanStack/store

feat(core): add support for comparing getter-only properties in shallow #222

Openjiji-hoon96(GitHub profile, opens in a new tab)wants to merge 2 commits intomain fromrefs/pull/222/headopened

  • Fix shallow comparison for objects with only getter properties
  • Add conditional logic to check getter properties when Object.keys() returns empty array
  • Use Object.getOwnPropertyDescriptors() to detect and compare getter values
  • Apply fix consistently across all framework packages (React, Vue, Svelte, Solid, Angular)
  • Add test case for getter-only objects to ensure proper functionality
  • Maintain backward compatibility and performance for regular objects

Fixes #218

    1. View your CI Pipeline Execution ↗ for commit 2cfc4585cb0614bc9aa3720f30bab176f3b830d2

      CommandStatusDurationResult
      nx affected --targets=test:sherif,test:knip,tes...✅ Succeeded55sView ↗
      nx run-many --target=build --exclude=examples/**✅ Succeeded11sView ↗

      ☁️ Nx Cloud last updated this comment at 2025-08-13 04:44:26 UTC

    2. @tanstack/angular-store

      npm i https://pkg.pr.new/@tanstack/angular-store@222

      @tanstack/react-store

      npm i https://pkg.pr.new/@tanstack/react-store@222

      @tanstack/solid-store

      npm i https://pkg.pr.new/@tanstack/solid-store@222

      @tanstack/store

      npm i https://pkg.pr.new/@tanstack/store@222

      @tanstack/svelte-store

      npm i https://pkg.pr.new/@tanstack/svelte-store@222

      @tanstack/vue-store

      npm i https://pkg.pr.new/@tanstack/vue-store@222

      commit: 2cfc458

Sign in to join this conversation.