fix(table-core): include sub-rows in flatRows when maxLeafRowFilterDepth truncates recursion #6361
beta fromrefs/pull/6361/head·opened Bug#
Closes #5987
When filterRowModelFromRoot skips recursing into sub-rows because depth >= maxLeafRowFilterDepth, the parent row's sub-rows remain accessible through row.subRows but were never added to newFilteredFlatRows. This makes flatRows an incomplete flat representation of the visible tree.
Root cause#
// filterRowsUtils.ts — filterRowModelFromRoot
if (pass) {
if (row.subRows.length && depth < maxDepth) {
// recursion adds sub-rows to newFilteredFlatRows ✓
newRow.subRows = recurseFilterRows(row.subRows, depth + 1)
}
// when depth >= maxDepth, sub-rows are on row.subRows but
// NEVER pushed to newFilteredFlatRows ← bug
newFilteredFlatRows.push(row)
}
Impact#
column.getFacetedUniqueValues() returns inconsistent counts:
- Before any filter:
flatRows= all rows at all depths (frompreRowModel) — counts sub-rows ✓ - After filtering with
maxLeafRowFilterDepth: 0:flatRows= only passing top-level rows — misses sub-rows ✗
Fix#
Added addSubRowsToFlatArrays helper that recursively pushes sub-rows into flatRows and rowsById when a passing row has sub-rows that were skipped due to depth >= maxDepth.
Verification#
New test file: packages/table-core/tests/unit/features/column-filtering/filterRowsUtils.test.ts
| Test | Before | After |
|---|---|---|
| No filter: flatRows has all 5 rows | ✅ | ✅ |
| maxLeafRowFilterDepth=100: sub-rows filtered normally | ✅ | ✅ |
| maxLeafRowFilterDepth=0, Alice passes: flatRows=3 (Alice+Charlie+Dave) | ❌ got 1 | ✅ |
| maxLeafRowFilterDepth=0, sub-row consistency | ❌ got 1 | ✅ |
Tests 4 passed (4)
All 359 existing tests continue to pass.
Summary by CodeRabbit#
- Bug Fixes
- Fixed hierarchical table filtering so that when filtering halts at a maximum depth, the visible nested sub-rows are still included and stay aligned in the flattened row list.
- Improved consistency between filtered and unfiltered results for nested rows.
- Tests
- Added unit tests covering nested column filtering behavior, including
maxLeafRowFilterDepthdifferences and expectedflatRowscounts.
- Added unit tests covering nested column filtering behavior, including
- 1
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID:
1128f10c-2774-4894-b4e6-8962343464fa📥 Commits
Reviewing files that changed from the base of the PR and between d5d357b8187c31999e962ee754aa48c99a3ef438 and 17dbb8e4d7abcab4d4f8ad81d80ca9cef0aca4a9.
📒 Files selected for processing (2)
packages/table-core/src/features/column-filtering/filterRowsUtils.tspackages/table-core/tests/unit/features/column-filtering/filterRowsUtils.test.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/table-core/src/features/column-filtering/filterRowsUtils.ts
- packages/table-core/tests/unit/features/column-filtering/filterRowsUtils.test.ts
📝 Walkthrough
Walkthrough#
Adds recursive sub-row flattening in
filterRowsUtils.tsso root-down filtering keeps visible nested rows inflatRowswhenmaxLeafRowFilterDepthstops recursion. A new unit test file checksflatRowscounts across unfiltered, depth-100, and depth-0 filtering cases.Changes#
flatRows fix for
maxLeafRowFilterDepthLayer / File(s) Summary Helper and depth-limit handling
packages/table-core/src/features/column-filtering/filterRowsUtils.tsDefines a recursive helper that adds nested sub-rows to flatRowsandrowsById, then uses it when root-down filtering stops atmaxLeafRowFilterDepth.Filtered row model tests
packages/table-core/tests/unit/features/column-filtering/filterRowsUtils.test.tsAdds a nested table test setup and verifies flatRowsoutput for unfiltered, depth-100, and depth-0 filtering scenarios.Estimated code review effort#
🎯 2 (Simple) | ⏱️ ~10 minutes
Poem#
🐇 When depth said “halt,” the rows still stayed, In flatRows, nested paths არიან laid. A bunny hops through trees of lines, And every sub-row neatly shines.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)#
Check name Status Explanation Resolution Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold. ✅ Passed checks (4 passed)
Check name Status Explanation Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled. Title check ✅ Passed The title clearly describes the main fix: keeping sub-rows in flatRows when recursion is truncated by maxLeafRowFilterDepth. Linked Issues check ✅ Passed The change restores skipped sub-rows to the filtered flat row model, which addresses the maxLeafRowFilterDepth: 0 consistency issue. Out of Scope Changes check ✅ Passed The diff stays focused on filtering internals and unit tests, with no unrelated feature work or public API changes. ✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment `@coderabbitai help` to get the list of available commands.Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Inline comments: In `@packages/table-core/src/features/column-filtering/filterRowsUtils.ts`: - Around line 164-170: The depth-limit branch in recurseFilterRows is appending visible subRows after the current row, which breaks the usual descendant-before-parent flatRows order. Update the branch that handles row.subRows with depth >= maxDepth so it preserves the same traversal ordering as the normal recursion path, using addSubRowsToFlatArrays and the surrounding filtered row accumulation logic to keep flatRows consistent regardless of maxLeafRowFilterDepth.🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID:
10271759-df3d-4e9f-b330-c4cb64286554📥 Commits
Reviewing files that changed from the base of the PR and between b7b05a9d8b53d3ea1a51d587bb483cb4cd88da93 and d5d357b8187c31999e962ee754aa48c99a3ef438.
📒 Files selected for processing (2)
packages/table-core/src/features/column-filtering/filterRowsUtils.tspackages/table-core/tests/unit/features/column-filtering/filterRowsUtils.test.ts
packages/table-core/src/features/column-filtering/filterRowsUtils.ts lines 164 to 174@@ -144,3 +161,10 @@144161 filteredRows.push(row)145162 newFilteredFlatRows.push(row)146163 newFilteredRowsById[row.id] = row164+ // When sub-rows exist but weren't recursed into (depth >= maxDepth),165+ // they are still visible in the row tree. Add them to flatRows so that166+ // flatRows is a complete flat representation of all visible rows,167+ // consistent with the no-filter case.168+ if (row.subRows.length && depth >= maxDepth) {169+ addSubRowsToFlatArrays(row.subRows, newFilteredFlatRows, newFilteredRowsById)170+ }🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Preserve
flatRowstraversal order in the depth-limit branch.recurseFilterRows()normally appends descendants before their parent, but this branch pushesrowfirst and only then appends the skipped descendants. That makesflatRowsorder change when the only thing that changes ismaxLeafRowFilterDepth.Suggested fix
- filteredRows.push(row) - newFilteredFlatRows.push(row) - newFilteredRowsById[row.id] = row // When sub-rows exist but weren't recursed into (depth >= maxDepth), // they are still visible in the row tree. Add them to flatRows so that // flatRows is a complete flat representation of all visible rows, // consistent with the no-filter case. if (row.subRows.length && depth >= maxDepth) { addSubRowsToFlatArrays(row.subRows, newFilteredFlatRows, newFilteredRowsById) } + filteredRows.push(row) + newFilteredFlatRows.push(row) + newFilteredRowsById[row.id] = row📝 Committable suggestion
‼️ IMPORTANT Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
// When sub-rows exist but weren't recursed into (depth >= maxDepth), // they are still visible in the row tree. Add them to flatRows so that // flatRows is a complete flat representation of all visible rows, // consistent with the no-filter case. if (row.subRows.length && depth >= maxDepth) { addSubRowsToFlatArrays(row.subRows, newFilteredFlatRows, newFilteredRowsById) } filteredRows.push(row) newFilteredFlatRows.push(row) newFilteredRowsById[row.id] = row🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/table-core/src/features/column-filtering/filterRowsUtils.ts` around lines 164 - 170, The depth-limit branch in recurseFilterRows is appending visible subRows after the current row, which breaks the usual descendant-before-parent flatRows order. Update the branch that handles row.subRows with depth >= maxDepth so it preserves the same traversal ordering as the normal recursion path, using addSubRowsToFlatArrays and the surrounding filtered row accumulation logic to keep flatRows consistent regardless of maxLeafRowFilterDepth.View your CI Pipeline Execution ↗ for commit 17dbb8e4d7abcab4d4f8ad81d80ca9cef0aca4a9
Command Status Duration Result nx affected --targets=test:eslint,test:sherif,t...❌ Failed 6m 1s View ↗ nx run-many --targets=build --exclude=examples/**✅ Succeeded 26s View ↗
☁️ Nx Cloud last updated this comment at
2026-06-30 19:12:44UTCMore templates
- tanstack-angular-table-example-basic-app-table
- tanstack-angular-table-example-basic-external-atoms
- tanstack-angular-table-example-basic-external-state
- tanstack-angular-table-example-basic-inject-table
- tanstack-angular-table-example-column-groups
- tanstack-angular-table-example-column-ordering
- tanstack-angular-table-example-column-pinning
- tanstack-angular-table-example-column-pinning-split
- tanstack-angular-table-example-column-pinning-sticky
- tanstack-angular-table-example-column-resizing
- tanstack-angular-table-example-column-resizing-performant
- tanstack-angular-table-example-column-sizing
- tanstack-angular-table-example-column-visibility
- tanstack-angular-table-example-composable-tables
- tanstack-angular-table-example-custom-plugin
- tanstack-angular-table-example-editable
- tanstack-angular-table-example-expanding
- tanstack-angular-table-example-filters
- tanstack-angular-table-example-filters-faceted
- tanstack-angular-table-example-filters-fuzzy
- tanstack-angular-table-example-grouping
- tanstack-angular-table-example-kitchen-sink
- tanstack-angular-table-example-pagination
- tanstack-angular-table-example-remote-data
- tanstack-angular-table-example-row-dnd
- tanstack-angular-table-example-row-pinning
- tanstack-angular-table-example-row-selection
- tanstack-angular-table-example-row-selection-signal
- tanstack-angular-table-example-signal-input
- tanstack-angular-table-example-sorting
- tanstack-angular-table-example-sub-components
- tanstack-angular-table-example-virtualized-columns
- tanstack-angular-table-example-virtualized-infinite-scrolling
- tanstack-angular-table-example-virtualized-rows
- tanstack-angular-table-example-with-tanstack-form
- tanstack-angular-table-example-with-tanstack-query
- tanstack-lit-table-example-basic-app-table
- tanstack-lit-table-example-basic-external-atoms
- tanstack-lit-table-example-basic-external-state
- tanstack-lit-table-example-basic-subscribe
- tanstack-lit-table-example-basic-table-controller
- tanstack-lit-table-example-column-groups
- tanstack-lit-table-example-column-ordering
- tanstack-lit-table-example-column-pinning
- tanstack-lit-table-example-column-pinning-split
- tanstack-lit-table-example-column-pinning-sticky
- tanstack-lit-table-example-column-resizing
- tanstack-lit-table-example-column-resizing-performant
- tanstack-lit-table-example-column-sizing
- tanstack-lit-table-example-column-visibility
- tanstack-lit-table-example-composable-tables
- tanstack-lit-table-example-expanding
- tanstack-lit-table-example-filters
- tanstack-lit-table-example-filters-faceted
- tanstack-lit-table-example-filters-fuzzy
- tanstack-lit-table-example-grouping
- tanstack-lit-table-example-kitchen-sink
- tanstack-lit-table-example-pagination
- tanstack-lit-table-example-row-pinning
- tanstack-lit-table-example-row-selection
- tanstack-lit-table-example-sorting
- tanstack-lit-table-example-sorting-dynamic-data
- tanstack-lit-table-example-sub-components
- tanstack-lit-table-example-virtualized-columns
- tanstack-lit-table-example-virtualized-infinite-scrolling
- tanstack-lit-table-example-virtualized-rows
- tanstack-preact-table-example-basic-external-atoms
- tanstack-preact-table-example-basic-external-state
- tanstack-preact-table-example-basic-subscribe
- tanstack-preact-table-example-basic-use-app-table
- tanstack-preact-table-example-basic-use-table
- tanstack-preact-table-example-column-groups
- tanstack-preact-table-example-column-ordering
- tanstack-preact-table-example-column-pinning
- tanstack-preact-table-example-column-pinning-split
- tanstack-preact-table-example-column-pinning-sticky
- tanstack-preact-table-example-column-resizing
- tanstack-preact-table-example-column-resizing-performant
- tanstack-preact-table-example-column-sizing
- tanstack-preact-table-example-column-visibility
- tanstack-preact-table-example-composable-tables
- tanstack-preact-table-example-custom-plugin
- tanstack-preact-table-example-expanding
- tanstack-preact-table-example-filters
- tanstack-preact-table-example-filters-faceted
- tanstack-preact-table-example-filters-fuzzy
- tanstack-preact-table-example-grouping
- tanstack-preact-table-example-kitchen-sink
- tanstack-preact-table-example-pagination
- tanstack-preact-table-example-row-pinning
- tanstack-preact-table-example-row-selection
- tanstack-preact-table-example-sorting
- tanstack-preact-table-example-sub-components
- tanstack-preact-table-example-with-tanstack-form
- tanstack-preact-table-example-with-tanstack-query
- tanstack-solid-table-example-basic-app-table
- tanstack-solid-table-example-basic-external-atoms
- tanstack-solid-table-example-basic-external-state
- tanstack-solid-table-example-basic-use-table
- tanstack-solid-table-example-column-groups
- tanstack-solid-table-example-column-ordering
- tanstack-solid-table-example-column-pinning
- tanstack-solid-table-example-column-pinning-split
- tanstack-solid-table-example-column-pinning-sticky
- tanstack-solid-table-example-column-resizing
- tanstack-solid-table-example-column-resizing-performant
- tanstack-solid-table-example-column-sizing
- tanstack-solid-table-example-column-visibility
- tanstack-solid-table-example-composable-tables
- tanstack-solid-table-example-expanding
- tanstack-solid-table-example-filters
- tanstack-solid-table-example-filters-faceted
- tanstack-solid-table-example-filters-fuzzy
- tanstack-solid-table-example-grouping
- tanstack-solid-table-example-kitchen-sink
- tanstack-solid-table-example-pagination
- tanstack-solid-table-example-row-pinning
- tanstack-solid-table-example-row-selection
- tanstack-solid-table-example-sorting
- tanstack-solid-table-example-sub-components
- tanstack-solid-table-example-virtualized-columns
- tanstack-solid-table-example-virtualized-infinite-scrolling
- tanstack-solid-table-example-virtualized-rows
- tanstack-solid-table-example-with-tanstack-form
- tanstack-solid-table-example-with-tanstack-query
- tanstack-solid-table-example-with-tanstack-router
- tanstack-vanilla-table-example-basic
- tanstack-vanilla-table-example-pagination
- tanstack-vanilla-table-example-sorting
- tanstack-svelte-table-example-basic-app-table
- tanstack-svelte-table-example-basic-create-table
- tanstack-svelte-table-example-basic-external-atoms
- tanstack-svelte-table-example-basic-external-state
- tanstack-svelte-table-example-basic-snippets
- tanstack-svelte-table-example-column-groups
- tanstack-svelte-table-example-column-ordering
- tanstack-svelte-table-example-column-pinning
- tanstack-svelte-table-example-column-pinning-split
- tanstack-svelte-table-example-column-pinning-sticky
- tanstack-svelte-table-example-column-resizing
- tanstack-svelte-table-example-column-resizing-performant
- tanstack-svelte-table-example-column-sizing
- tanstack-svelte-table-example-column-visibility
- tanstack-svelte-table-example-composable-tables
- tanstack-svelte-table-example-expanding
- tanstack-svelte-table-example-filtering
- tanstack-svelte-table-example-filters-faceted
- tanstack-svelte-table-example-filters-fuzzy
- tanstack-svelte-table-example-grouping
- tanstack-svelte-table-example-kitchen-sink
- tanstack-svelte-table-example-pagination
- tanstack-svelte-table-example-row-pinning
- tanstack-svelte-table-example-row-selection
- tanstack-svelte-table-example-sorting
- tanstack-svelte-table-example-sub-components
- tanstack-svelte-table-example-virtualized-columns
- tanstack-svelte-table-example-virtualized-infinite-scrolling
- tanstack-svelte-table-example-virtualized-rows
- tanstack-svelte-table-example-with-tanstack-form
- tanstack-svelte-table-example-with-tanstack-query
- tanstack-react-table-example-basic-external-atoms
- tanstack-react-table-example-basic-external-state
- tanstack-react-table-example-basic-subscribe
- tanstack-react-table-example-basic-use-app-table
- tanstack-react-table-example-basic-use-legacy-table
- tanstack-react-table-example-basic-use-table
- tanstack-react-table-example-column-dnd
- tanstack-react-table-example-column-groups
- tanstack-react-table-example-column-ordering
- tanstack-react-table-example-column-pinning
- tanstack-react-table-example-column-pinning-split
- tanstack-react-table-example-column-pinning-sticky
- tanstack-react-table-example-column-resizing
- tanstack-react-table-example-column-resizing-performant
- tanstack-react-table-example-column-sizing
- tanstack-react-table-example-column-visibility
- tanstack-react-table-example-composable-tables
- tanstack-react-table-example-custom-plugin
- tanstack-react-table-example-expanding
- tanstack-react-table-example-filters
- tanstack-react-table-example-filters-faceted
- tanstack-react-table-example-filters-fuzzy
- tanstack-react-table-example-grouping
- tanstack-react-table-example-kitchen-sink
- tanstack-react-table-example-kitchen-sink-hero-ui
- tanstack-react-table-example-kitchen-sink-mantine
- tanstack-react-table-example-kitchen-sink-material-ui
- tanstack-react-table-example-kitchen-sink-react-aria
- tanstack-react-table-example-kitchen-sink-shadcn-base
- tanstack-react-table-example-kitchen-sink-shadcn-radix
- tanstack-react-table-example-lib-hero-ui
- tanstack-react-table-example-lib-mantine
- tanstack-react-table-example-lib-material-ui
- tanstack-react-table-example-lib-react-aria
- tanstack-react-table-example-lib-shadcn-base
- tanstack-react-table-example-lib-shadcn-radix
- tanstack-react-table-example-mantine-react-table
- tanstack-react-table-example-material-react-table
- tanstack-react-table-example-pagination
- tanstack-react-table-example-row-dnd
- tanstack-react-table-example-row-pinning
- tanstack-react-table-example-row-selection
- tanstack-react-table-example-sorting
- tanstack-react-table-example-sub-components
- tanstack-react-table-example-virtualized-columns
- tanstack-react-table-example-virtualized-columns-experimental
- tanstack-react-table-example-virtualized-infinite-scrolling
- tanstack-react-table-example-virtualized-rows
- tanstack-react-table-example-virtualized-rows-experimental
- tanstack-react-table-example-with-tanstack-form
- tanstack-react-table-example-with-tanstack-query
- tanstack-react-table-example-with-tanstack-router
- tanstack-vue-table-example-basic-external-atoms
- tanstack-vue-table-example-basic-external-state
- tanstack-vue-table-example-basic-use-app-table
- tanstack-vue-table-example-basic-use-table
- tanstack-vue-table-example-column-groups
- tanstack-vue-table-example-column-ordering
- tanstack-vue-table-example-column-pinning
- tanstack-vue-table-example-column-pinning-split
- tanstack-vue-table-example-column-pinning-sticky
- tanstack-vue-table-example-column-resizing
- tanstack-vue-table-example-column-resizing-performant
- tanstack-vue-table-example-column-sizing
- tanstack-vue-table-example-column-visibility
- tanstack-vue-table-example-composable-tables
- tanstack-vue-table-example-expanding
- tanstack-vue-table-example-filters
- tanstack-vue-table-example-filters-faceted
- tanstack-vue-table-example-filters-fuzzy
- tanstack-vue-table-example-grouping
- tanstack-vue-table-example-kitchen-sink
- tanstack-vue-table-example-pagination
- tanstack-vue-table-example-row-pinning
- tanstack-vue-table-example-row-selection
- tanstack-vue-table-example-sorting
- tanstack-vue-table-example-sub-components
- tanstack-vue-table-example-virtualized-columns
- tanstack-vue-table-example-virtualized-infinite-scrolling
- tanstack-vue-table-example-virtualized-rows
- tanstack-vue-table-example-with-tanstack-form
- tanstack-vue-table-example-with-tanstack-query
@tanstack/angular-table
npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6361@tanstack/angular-table-devtools
npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6361@tanstack/lit-table
npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6361@tanstack/match-sorter-utils
npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6361@tanstack/preact-table
npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6361@tanstack/preact-table-devtools
npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6361@tanstack/react-table
npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6361@tanstack/react-table-devtools
npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6361@tanstack/solid-table
npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6361@tanstack/solid-table-devtools
npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6361@tanstack/svelte-table
npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6361@tanstack/table-core
npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6361@tanstack/table-devtools
npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6361@tanstack/vue-table
npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6361@tanstack/vue-table-devtools
npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6361commit:
17dbb8eNx Cloud is proposing a fix for your failed CI:#
We moved
filteredRowModelandfilterFnsfrom theconstructTablefeaturesoption into the top-leveltableFeatures()call, which is where TypeScript resolves valid filter function key names viaExtractFilterFnKeys<TFeatures>. This fixes both TS2322 ('includesString'not assignable) and TS2353 (filteredRowModelnot a known property on the features object), bringing the test file in line with the canonical pattern used elsewhere in the workspace.Tip
✅ We verified this fix by re-running
@tanstack/table-core:test:types.diff --git a/packages/table-core/tests/unit/features/column-filtering/filterRowsUtils.test.ts b/packages/table-core/tests/unit/features/column-filtering/filterRowsUtils.test.ts index 2a06d8d8..fe30f6fa 100644 --- a/packages/table-core/tests/unit/features/column-filtering/filterRowsUtils.test.ts +++ b/packages/table-core/tests/unit/features/column-filtering/filterRowsUtils.test.ts @@ -12,7 +12,12 @@ import type { ColumnDef, ColumnFiltersState } from '../../../../src' type Row = { name: string; subRows?: Row[] } -const features = tableFeatures({ ...coreFeatures, columnFilteringFeature }) +const features = tableFeatures({ + ...coreFeatures, + columnFilteringFeature, + filteredRowModel: createFilteredRowModel(), + filterFns, +}) function makeNestedTable(opts?: { maxLeafRowFilterDepth?: number @@ -51,8 +56,6 @@ function makeNestedTable(opts?: { }, features: { ...features, - filteredRowModel: createFilteredRowModel(), - filterFns, coreReactivityFeature: storeReactivityBindings(), }, })Because this branch comes from a fork, it is not possible for us to apply fixes directly, but you can apply the changes locally using the available options below.
Apply changes locally with:
Apply fix locally with your editor ↗ View interactive diff ↗npx nx-cloud apply-locally dqWa-F83o
🎓 Learn more about Self-Healing CI on [nx.dev](https://nx.dev/docs/features/ci-features/self-healing-ci?utm_source=pull-request&utm_medium=comment)KevinVandy closed this
Sign in to join this conversation.
copilot-pull-request-reviewer[bot](GitHub profile, opens in a new tab) reviewed
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.