Skip to content
Source
Sign inSign up

pingdotgg

t3codePublic Synced with GitHub
Popular #1 Fork 0

fix(web): a sidebar thread row shows its full repo name when there is room #35949

Send to my agent
Openflamboh(GitHub profile, opens in a new tab)wants to merge 1 commit intomaria/redesign/6-workspace-panes fromrefs/pull/35949/headopened View on GitHub

flamboh(GitHub profile, opens in a new tab)commented

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Fix for the redesign stack, targets layer 6 (#28845).

Problem

In a narrow sidebar, a thread row cut its repo name short (t3-pr-…) even when the row only showed a short age like 6m and had plenty of empty space. main does not cut it there.

The hidden hover actions (pin, snooze, Settle) still took up width in the status slot while invisible, so the slot was always about 97px wide. The slot also had a 60px minimum width, where main uses 32px.

Fix

The hover actions take no space until they show: they stay absolutely positioned while hidden and join the layout on hover, on keyboard focus, or while the snooze menu is open, as on main. The slot's minimum width goes back to main's min-w-8.

At a 208px sidebar, an idle row's repo name now gets 111px, so t3-pr-ui-sandbox fits. A row with a status like Done still gives the status the room it needs. On hover, the actions push the name back to the same width as before. The status, age, and hover actions look unchanged.

Before / after

Sidebar at its 208px minimum, then at 320px. Look at the repo name on the rows that show only an age.

Before and after: in a narrow sidebar the repo name on idle rows was cut to "t3-pr-…"; now it shows in full. Hovered and wide states match.

Hovering a row, real speed. Watch the repo name when the pointer moves onto the row.

https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/f75613d97a720b71/before-after-hover.mp4

For Maria: this trades away part of "hover controls keep a stable slot". The slot no longer holds the hover actions' width while they are hidden, so on hover the repo name shortens by 65px to make room, as on main. The age and status do not move and the row height stays the same. If a stable slot matters more than the full name, the alternative is to keep the reserved width and close this PR.

Validation

  • Measured in a real browser on both sides, with the sidebar at 208px and 320px: slot width, name width, and whether the name is cut, for idle rows, Done rows, and a hovered row.
  • vp run check:changed origin/maria/redesign/6-workspace-panes: format, lint, knip, typecheck, and React Compiler all pass.

Made with Claude Opus 5.5 in Claude Code.

    1. tanstack-source added labelsbug

    2. github-actions[bot](GitHub profile, opens in a new tab) added labelsvouch:trusted

    3. github-actions[bot](GitHub profile, opens in a new tab) added labelssize:XS

    5. macroscopeapp[bot](GitHub profile, opens in a new tab)commented

      Approvability

      Verdict: Approved at 77a572a

      Macroscope's review found this PR approvable — This gives repository names more sidebar space by keeping hidden action controls out of the layout until needed. The change is presentation-only, with no changes to action handlers or stored data.

      You can add or adjust custom eligibility rules. [Learn more](https://docs.macroscope.com/approvability#example-custom-eligibility-rules).

Sign in to join this conversation.