fix(cli): service.env updates keep quoted multiline values intact #35976

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

The service environment updater now treats quoted multiline assignments as spans when updating keys. Tests verify that assignment-like lines within quoted values remain intact and that the top-level T3CODE_LAN setting is added or updated.

Changes: Service environment updates

Layer / File(s)	Summary
Multiline assignment matching apps/server/src/cli/service.ts, apps/server/src/cli/service.test.ts, apps/server/src/cli/up.test.ts	upsertServiceEnv processes quoted multiline assignments as spans. Tests cover embedded T3CODE_LAN text, adding or replacing the setting, and preserving a long custom value.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related PRs

• pingdotgg/t3code#27996: Adds the T3CODE_LAN write path that uses upsertServiceEnv.

Suggested labels: bugfix

Suggested reviewers: t3dotgg, macroscopeapp, saphid

Merge Risk: Low · up to 4e936

The change correctly keeps quoted multiline values intact when T3CODE_LAN is updated. One edge case remains: a value written as KEY= with the opening quote on the next line can still have an embedded line rewritten, and the top-level setting is then not written. This is a rare input and a small fix, and the author should address it before merging.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Linked Issues check		[#35944] The code change in apps/server/src/cli/service.ts groups a quoted multiline assignment into one span. SERVICE_ENV_KEY accepts an optional export prefix, and the opening-quote check accepts ',…	Add an upsertServiceEnv assertion in apps/server/src/cli/up.test.ts for a single-quoted multiline value with an export prefix that contains a T3CODE_LAN=-shaped line, for example "export CUSTOM='x\nT3CODE_LAN=y'\nT3CODE_LAN=true\n" with T3C…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title names the main change: service.env updates in the CLI now keep quoted multiline values intact. It uses the conventional commit form and matches the changeset, which groups multiline quoted a…
Out of Scope Changes check		All changes in the whole-PR diff (merge base 97cfc07759 to head 4e93602844) serve issue #35944. service.ts changes group quoted multiline spans and use the parseEnv-matching skip set [ \t\r] before th…
Description check		The description covers the required sections. Problem: upsertServiceEnv treats assignment-shaped lines inside quoted multiline values as top-level keys, and it trims Unicode whitespace (such as NBSP) …

Full details: Title check

Explanation

The title names the main change: service.env updates in the CLI now keep quoted multiline values intact. It uses the conventional commit form and matches the changeset, which groups multiline quoted assignments in upsertServiceEnv and adds tests for them. It does not mention the NBSP or whitespace-handling change, but that is a secondary detail.

Full details: Out of Scope Changes check

Explanation

All changes in the whole-PR diff (merge base 97cfc07759 to head 4e93602844) serve issue #35944. service.ts changes group quoted multiline spans and use the parseEnv-matching skip set [ \t\r] before the opening quote. The skip is a single anchored regex. up.test.ts adds assertions for the bug, the NBSP case, and a 130,000-newline value. That large-value case checks that the span grouping does not overflow the stack. service.test.ts adds one install-path row for the bug. No unrelated files or behavior changes were found in the reviewed diffs.

Full details: Description check

Explanation

The description covers the required sections. Problem: upsertServiceEnv treats assignment-shaped lines inside quoted multiline values as top-level keys, and it trims Unicode whitespace (such as NBSP) before detecting an opening quote, so it misreads the span. Change: the quoted multiline span is kept or replaced as one entry, and the whitespace skip is limited to space, tab, and CR to match util.parseEnv. Scope: it links issue #35944 and gives a reason for the bug fix. Verification: it gives reproduction steps on the base commit, real CLI runs with before and after transcripts, focused test results (39/39), and a check run. It also lists what was not tested, namely a real OS service manager and other quote styles. The attribution line names the model and harness. The template's sections are all present and substantively filled in, so the description is mostly complete.

Full details: Linked Issues check

Explanation

[#35944] The code change in apps/server/src/cli/service.ts groups a quoted multiline assignment into one span. SERVICE_ENV_KEY accepts an optional export prefix, and the opening-quote check accepts ', " and backtick. So the single-quoted export case is handled by the logic. The requested test coverage is incomplete. The added up.test.ts assertions cover a double-quoted multiline value with a T3CODE_LAN-shaped line, a whitespace-prefixed NBSP assignment, and a 130,000-newline value. None of them covers a single-quoted value with an export prefix, which the issue names explicitly. The issue also asks to retain single-line and escaped-newline behavior. The existing tests cover that. The PR description reports no real OS service manager test. The issue states that this is out of the stated scope, so it is not a coding requirement here.

Resolution

Add an upsertServiceEnv assertion in apps/server/src/cli/up.test.ts for a single-quoted multiline value with an export prefix that contains a T3CODE_LAN=-shaped line, for example "export CUSTOM='x\nT3CODE_LAN=y'\nT3CODE_LAN=true\n" with T3CODE_LAN: "false". Confirm the output keeps CUSTOM intact and replaces only the top-level T3CODE_LAN entry.

Generate unit tests (beta)

• Commit to this branch
• Create a new PR