ci: restore Electric E2E tests #2076
main fromrefs/pull/2076/head·merged by KyleAMathews(GitHub profile, opens in a new tab) 🎯 Changes#
The electricsql/electric:canary image is available again. Remove the temporary ELECTRIC_E2E skip flag added in #1985. The browser E2E group will start Docker services, run the Electric collection suite and the live Electric OPFS suite, then stop the services. This restores CI coverage for the shared suites tracked in #772.
✅ Checklist#
- I have tested this code locally with
pnpm test. Local Docker access is unavailable; the restored E2E lane will run on this PR. - The workflow YAML parses and
git diff --checkpasses.
🚀 Release Impact#
- This change is CI-only (no release).
Summary by CodeRabbit#
- Tests
- Browser end-to-end checks now run across all browser test groups, including Electric and OPFS scenarios. Docker cleanup also runs when a test job fails.
- 1
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
- Configuration used: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
67c73e8c-040e-4c06-88c0-e8195a98dc8d
📥 Commits
Reviewing files that changed from the base of the PR and between 2c98b4992c412820f8476325ee6941db5ca9ac0f and 701c295d2c126db12aa79bdfea60c7b87772dd53.
📒 Files selected for processing (1)
.github/workflows/e2e-tests.yml
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 1 remain after this review.
📝 Walkthrough
Walkthrough#
The browser E2E workflow now starts Docker services, runs Electric and live-Electric OPFS tests, and stops Docker services for every browser matrix group. The
ELECTRIC_E2Ejob-level flag and related conditions were removed.Changes#
Browser E2E workflow
Layer / File(s) Summary Run Electric E2E coverage in browser groups
.github/workflows/e2e-tests.ymlThe workflow starts Docker services, runs Electric and live-Electric OPFS tests, and stops services for every browser group. Cleanup runs regardless of job outcome. Priority: ⬇️ Low
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Suggested reviewers:
sonnesMerge Risk: ⚪ Minimal · up to
701c2This CI-only change restores the Electric end-to-end test lanes. It does not affect runtime behavior, and no concrete merge-blocking risk remains.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation Title check ✅ Passed The title clearly and concisely identifies the main change: restoring the Electric E2E tests in CI. Description check ✅ Passed The description includes all required template sections, explains the motivation and workflow changes, records the testing limitation, and identifies the change as CI-only with no release impact. Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request. ✨ Finishing Touches
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment `@coderabbitai help` to get the list of available commands.Size Change: 0 B
Total Size: 202 kB
compressed-size-action::db-and-react-package-sizeℹ️ View Unchanged
Filename Size packages/db/dist/esm/client.js3.66 kB packages/db/dist/esm/collection-options.js236 B packages/db/dist/esm/collection/change-events.js1.64 kB packages/db/dist/esm/collection/changes.js2.93 kB packages/db/dist/esm/collection/cleanup-queue.js808 B packages/db/dist/esm/collection/config-errors.js547 B packages/db/dist/esm/collection/events.js481 B packages/db/dist/esm/collection/index.js4.99 kB packages/db/dist/esm/collection/indexes.js2.23 kB packages/db/dist/esm/collection/lifecycle.js2.82 kB packages/db/dist/esm/collection/mutations.js2.92 kB packages/db/dist/esm/collection/state.js6.94 kB packages/db/dist/esm/collection/subscription.js8.72 kB packages/db/dist/esm/collection/sync.js5.27 kB packages/db/dist/esm/collection/validate-config.js1.11 kB packages/db/dist/esm/deferred.js207 B packages/db/dist/esm/errors.js5.74 kB packages/db/dist/esm/event-emitter.js961 B packages/db/dist/esm/index.js4.38 kB packages/db/dist/esm/indexed-db-wrapper.js1.63 kB packages/db/dist/esm/indexed-db.js3.55 kB packages/db/dist/esm/indexes/auto-index.js841 B packages/db/dist/esm/indexes/base-index.js1.38 kB packages/db/dist/esm/indexes/basic-index.js1.96 kB packages/db/dist/esm/indexes/btree-index.js2.29 kB packages/db/dist/esm/indexes/index-registry.js820 B packages/db/dist/esm/indexes/reverse-index.js1 kB packages/db/dist/esm/live-query-adapter.js338 B packages/db/dist/esm/live-query-observer.js4.64 kB packages/db/dist/esm/live-query-options.js1.07 kB packages/db/dist/esm/live-query-window-controller.js4.18 kB packages/db/dist/esm/local-only.js1.08 kB packages/db/dist/esm/local-storage.js2.18 kB packages/db/dist/esm/optimistic-action.js359 B packages/db/dist/esm/paced-mutations.js1.05 kB packages/db/dist/esm/persisted-readiness.js195 B packages/db/dist/esm/proxy.js3.43 kB packages/db/dist/esm/query/builder/clone-query.js766 B packages/db/dist/esm/query/builder/functions.js1.45 kB packages/db/dist/esm/query/builder/index.js6.75 kB packages/db/dist/esm/query/builder/query-ir.js116 B packages/db/dist/esm/query/builder/ref-proxy-identity.js292 B packages/db/dist/esm/query/builder/ref-proxy.js1.48 kB packages/db/dist/esm/query/builder/wrapper-identity.js221 B packages/db/dist/esm/query/compiler/evaluators.js2.22 kB packages/db/dist/esm/query/compiler/expressions.js604 B packages/db/dist/esm/query/compiler/group-by.js4.2 kB packages/db/dist/esm/query/compiler/index.js9.39 kB packages/db/dist/esm/query/compiler/joins.js3.2 kB packages/db/dist/esm/query/compiler/lazy-targets.js1.14 kB packages/db/dist/esm/query/compiler/order-by.js2.04 kB packages/db/dist/esm/query/compiler/parent-routes.js319 B packages/db/dist/esm/query/compiler/query-equivalence.js448 B packages/db/dist/esm/query/compiler/route-metadata.js1.24 kB packages/db/dist/esm/query/compiler/select.js1.59 kB packages/db/dist/esm/query/effect.js4.86 kB packages/db/dist/esm/query/equality-conjunct.js486 B packages/db/dist/esm/query/equality-value-identity.js591 B packages/db/dist/esm/query/expression-helpers.js1.45 kB packages/db/dist/esm/query/ir-stable-identity.js4.2 kB packages/db/dist/esm/query/ir.js1.7 kB packages/db/dist/esm/query/join-conditions.js257 B packages/db/dist/esm/query/live-query-collection.js391 B packages/db/dist/esm/query/live/bucket-facade-adapter.js2.67 kB packages/db/dist/esm/query/live/collection-config-builder.js6.63 kB packages/db/dist/esm/query/live/collection-registry.js264 B packages/db/dist/esm/query/live/collection-subscriber.js2.15 kB packages/db/dist/esm/query/live/graph-scheduler.js305 B packages/db/dist/esm/query/live/internal.js145 B packages/db/dist/esm/query/live/materialized-pipeline.js2.32 kB packages/db/dist/esm/query/live/ordered-source-loader.js4.38 kB packages/db/dist/esm/query/live/subset-demand-controller.js1.65 kB packages/db/dist/esm/query/live/utils.js1.2 kB packages/db/dist/esm/query/optimizer.js2.84 kB packages/db/dist/esm/query/pooled-live-query.js4.1 kB packages/db/dist/esm/query/query-once.js359 B packages/db/dist/esm/query/runtime-reference-identity.js630 B packages/db/dist/esm/query/subset-dedupe.js493 B packages/db/dist/esm/scheduler.js1.13 kB packages/db/dist/esm/SortedMap.js1.6 kB packages/db/dist/esm/strategies/commit-completion.js156 B packages/db/dist/esm/strategies/debounceStrategy.js658 B packages/db/dist/esm/strategies/queueStrategy.js523 B packages/db/dist/esm/strategies/serial-pacer.js486 B packages/db/dist/esm/strategies/throttleStrategy.js738 B packages/db/dist/esm/sync-persistence.js540 B packages/db/dist/esm/sync-receipt.js211 B packages/db/dist/esm/transactions.js4.2 kB packages/db/dist/esm/utils.js1.49 kB packages/db/dist/esm/utils/array-utils.js270 B packages/db/dist/esm/utils/browser-polyfills.js304 B packages/db/dist/esm/utils/btree.js3.02 kB packages/db/dist/esm/utils/callbacks.js174 B packages/db/dist/esm/utils/comparison.js1.59 kB packages/db/dist/esm/utils/cursor.js677 B packages/db/dist/esm/utils/error.js167 B packages/db/dist/esm/utils/get-or-create.js155 B packages/db/dist/esm/utils/index-optimization.js2.43 kB packages/db/dist/esm/utils/source-record.js140 B packages/db/dist/esm/utils/type-guards.js230 B packages/db/dist/esm/utils/uuid.js449 B packages/db/dist/esm/virtual-props.js413 B packages/react-db/dist/esm/DbProvider.js317 B packages/react-db/dist/esm/development.js190 B packages/react-db/dist/esm/HydrationBoundary.js263 B packages/react-db/dist/esm/index.js330 B packages/react-db/dist/esm/live-query-internals.js282 B packages/react-db/dist/esm/source-id-bindings.js807 B packages/react-db/dist/esm/useLiveInfiniteQuery.js2.15 kB packages/react-db/dist/esm/useLiveQuery.js3.31 kB packages/react-db/dist/esm/useLiveQueryEffect.js355 B packages/react-db/dist/esm/useLiveSuspenseQuery.js1.33 kB packages/react-db/dist/esm/usePacedMutations.js401 B More templates
- todos
- offline-first-electron
- @tanstack/db-example-react-action-enforcement
- @tanstack/db-example-react-next-ssr-e2e
- tanstack-start-example-basic
- @tanstack/db-example-paced-mutations-demo
- tanstack-start-db-projects-example
- @tanstack/db-example-react-start-ssr-e2e
- @tanstack/db-example-react-todo
- offline-transactions-react-native
- shopping-list-react-native
- @tanstack/db-example-solid-todo
@tanstack/angular-db
npm i https://pkg.pr.new/@tanstack/angular-db@2076@tanstack/browser-db-sqlite-persistence
npm i https://pkg.pr.new/@tanstack/browser-db-sqlite-persistence@2076@tanstack/capacitor-db-sqlite-persistence
npm i https://pkg.pr.new/@tanstack/capacitor-db-sqlite-persistence@2076@tanstack/cloudflare-durable-objects-db-sqlite-persistence
npm i https://pkg.pr.new/@tanstack/cloudflare-durable-objects-db-sqlite-persistence@2076@tanstack/db
npm i https://pkg.pr.new/@tanstack/db@2076@tanstack/db-ivm
npm i https://pkg.pr.new/@tanstack/db-ivm@2076@tanstack/db-sqlite-persistence-core
npm i https://pkg.pr.new/@tanstack/db-sqlite-persistence-core@2076@tanstack/electric-db-collection
npm i https://pkg.pr.new/@tanstack/electric-db-collection@2076@tanstack/electron-db-sqlite-persistence
npm i https://pkg.pr.new/@tanstack/electron-db-sqlite-persistence@2076@tanstack/expo-db-sqlite-persistence
npm i https://pkg.pr.new/@tanstack/expo-db-sqlite-persistence@2076@tanstack/node-db-sqlite-persistence
npm i https://pkg.pr.new/@tanstack/node-db-sqlite-persistence@2076@tanstack/offline-transactions
npm i https://pkg.pr.new/@tanstack/offline-transactions@2076@tanstack/powersync-db-collection
npm i https://pkg.pr.new/@tanstack/powersync-db-collection@2076@tanstack/query-db-collection
npm i https://pkg.pr.new/@tanstack/query-db-collection@2076@tanstack/react-db
npm i https://pkg.pr.new/@tanstack/react-db@2076@tanstack/react-native-db-sqlite-persistence
npm i https://pkg.pr.new/@tanstack/react-native-db-sqlite-persistence@2076@tanstack/react-router-with-db
npm i https://pkg.pr.new/@tanstack/react-router-with-db@2076@tanstack/rxdb-db-collection
npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@2076@tanstack/solid-db
npm i https://pkg.pr.new/@tanstack/solid-db@2076@tanstack/svelte-db
npm i https://pkg.pr.new/@tanstack/svelte-db@2076@tanstack/tauri-db-sqlite-persistence
npm i https://pkg.pr.new/@tanstack/tauri-db-sqlite-persistence@2076@tanstack/trailbase-db-collection
npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@2076@tanstack/vue-db
npm i https://pkg.pr.new/@tanstack/vue-db@2076commit:
701c295KyleAMathews(GitHub profile, opens in a new tab) closed this
Sign in to join this conversation.
⚠️ No Changeset found#
Latest commit: 701c295d2c126db12aa79bdfea60c7b87772dd53
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR